Add some more scoped_ptr functions in values.h

Add some more scoped_ptr functions in values.h

And convert some existing usage of bare pointer functions to their
scoped_ptr counterparts.

BUG=none

Committed: https://crrev.com/7bc801fbcaa66b2d30c5e69da7f8318528b986a6
Cr-Commit-Position: refs/heads/master@{#328676}

[Evan Stade, 2015-05-04 23:48:58]

[email protected] changed reviewers:
+ [email protected]

[brettw, 2015-05-05 17:47:23]

Just some style nits. LGTM

https://codereview.chromium.org/1115423003/diff/20001/base/test/launcher/test...
File base/test/launcher/test_results_tracker.cc (right):

https://codereview.chromium.org/1115423003/diff/20001/base/test/launcher/test...
base/test/launcher/test_results_tracker.cc:242: scoped_ptr<ListValue>
global_tags(new ListValue());
No () (for consistency)

https://codereview.chromium.org/1115423003/diff/20001/base/test/launcher/test...
base/test/launcher/test_results_tracker.cc:243: for (auto global_tag :
global_tags_) {
const auto &

https://codereview.chromium.org/1115423003/diff/20001/base/test/launcher/test...
base/test/launcher/test_results_tracker.cc:249: for (auto test : all_tests_) {
ditto

https://codereview.chromium.org/1115423003/diff/20001/base/test/launcher/test...
base/test/launcher/test_results_tracker.cc:255: for (auto disabled_test :
disabled_tests_) {
ditto

https://codereview.chromium.org/1115423003/diff/20001/base/test/launcher/test...
base/test/launcher/test_results_tracker.cc:263: scoped_ptr<DictionaryValue>
current_iteration_data(new DictionaryValue());
No (), also a few more below.

https://codereview.chromium.org/1115423003/diff/20001/base/values_unittest.cc
File base/values_unittest.cc (right):

https://codereview.chromium.org/1115423003/diff/20001/base/values_unittest.cc...
base/values_unittest.cc:682: scoped_ptr<DictionaryValue> inner(new
DictionaryValue());
No (), also one below.

[Evan Stade, 2015-05-05 18:45:15]

https://codereview.chromium.org/1115423003/diff/20001/base/test/launcher/test...
File base/test/launcher/test_results_tracker.cc (right):

https://codereview.chromium.org/1115423003/diff/20001/base/test/launcher/test...
base/test/launcher/test_results_tracker.cc:242: scoped_ptr<ListValue>
global_tags(new ListValue());
On 2015/05/05 17:47:22, brettw wrote:
> No () (for consistency)

Done.

https://codereview.chromium.org/1115423003/diff/20001/base/test/launcher/test...
base/test/launcher/test_results_tracker.cc:243: for (auto global_tag :
global_tags_) {
On 2015/05/05 17:47:22, brettw wrote:
> const auto &

Done.

https://codereview.chromium.org/1115423003/diff/20001/base/test/launcher/test...
base/test/launcher/test_results_tracker.cc:249: for (auto test : all_tests_) {
On 2015/05/05 17:47:22, brettw wrote:
> ditto

Done.

https://codereview.chromium.org/1115423003/diff/20001/base/test/launcher/test...
base/test/launcher/test_results_tracker.cc:255: for (auto disabled_test :
disabled_tests_) {
On 2015/05/05 17:47:22, brettw wrote:
> ditto

Done.

https://codereview.chromium.org/1115423003/diff/20001/base/test/launcher/test...
base/test/launcher/test_results_tracker.cc:263: scoped_ptr<DictionaryValue>
current_iteration_data(new DictionaryValue());
On 2015/05/05 17:47:23, brettw wrote:
> No (), also a few more below.

Done.

https://codereview.chromium.org/1115423003/diff/20001/base/values_unittest.cc
File base/values_unittest.cc (right):

https://codereview.chromium.org/1115423003/diff/20001/base/values_unittest.cc...
base/values_unittest.cc:682: scoped_ptr<DictionaryValue> inner(new
DictionaryValue());
On 2015/05/05 17:47:23, brettw wrote:
> No (), also one below.

Done.

[Evan Stade, 2015-05-05 18:45:24]

The CQ bit was checked by [email protected] to run a CQ dry run

[Evan Stade, 2015-05-05 18:45:24]

The patchset sent to the CQ was uploaded after l-g-t-m from [email protected]
Link to the patchset: https://codereview.chromium.org/1115423003/#ps40001
(title: "brettw review")

[commit-bot: I haz the power, 2015-05-05 18:46:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1115423003/40001

[Evan Stade, 2015-05-05 20:18:06]

The CQ bit was unchecked by [email protected]

[Evan Stade, 2015-05-05 20:18:07]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2015-05-05 20:20:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1115423003/40001

[commit-bot: I haz the power, 2015-05-05 22:51:16]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2015-05-05 22:51:18]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2015-05-06 21:08:26]

The CQ bit was checked by [email protected]

[Evan Stade, 2015-05-06 21:08:26]

The patchset sent to the CQ was uploaded after l-g-t-m from [email protected]
Link to the patchset: https://codereview.chromium.org/1115423003/#ps60001
(title: "mysterious failures are transient?")

[commit-bot: I haz the power, 2015-05-06 21:10:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1115423003/60001

[Evan Stade, 2015-05-06 23:34:59]

The CQ bit was checked by [email protected]

[Evan Stade, 2015-05-06 23:35:00]

The patchset sent to the CQ was uploaded after l-g-t-m from [email protected]
Link to the patchset: https://codereview.chromium.org/1115423003/#ps80001
(title: "asan to the rescue")

[commit-bot: I haz the power, 2015-05-06 23:36:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1115423003/80001

[commit-bot: I haz the power, 2015-05-07 01:53:22]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-05-07 01:54:18]

Patchset 5 (id:??) landed as
https://crrev.com/7bc801fbcaa66b2d30c5e69da7f8318528b986a6
Cr-Commit-Position: refs/heads/master@{#328676}