Porting the app launcher to Windows, and adding an experimental flag...

Porting the app launcher to Windows, and adding an experimental flag
so the app launcher shows when you open a new tab.
Also removing the graying-out of the browser when the app launcher is showng for now, as
it is not clear how to make it cross-platform.

BUG=None
TEST=Start Chrome with --app-launcher-new-tab. Opening a new tab
     should bring the app launcher (still a prototype at this point).


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42280

[sky, 2010-03-19 22:56:59]

http://codereview.chromium.org/1145001/diff/52002/17002
File chrome/browser/views/app_launcher.cc (right):

http://codereview.chromium.org/1145001/diff/52002/17002#newcode179
chrome/browser/views/app_launcher.cc:179: font = font.DeriveFont(3);
Make 3 a constant.

http://codereview.chromium.org/1145001/diff/52002/17002#newcode189
chrome/browser/views/app_launcher.cc:189: autocomplete_view->SetUserText(L"");
std::wstring

http://codereview.chromium.org/1145001/diff/52002/17002#newcode414
chrome/browser/views/app_launcher.cc:414: return NULL;
If you enter this if, you leak app_launcher.

http://codereview.chromium.org/1145001/diff/52002/17002#newcode425
chrome/browser/views/app_launcher.cc:425: gtk_widget_realize(rwhv_widget);
A comment as to why this is needed would be nice.

http://codereview.chromium.org/1145001/diff/52002/17002#newcode496
chrome/browser/views/app_launcher.cc:496: pending_contents_.reset(NULL);
Do you really need to do either of these things? Won't it be handled for you by
way of delete this?

[jcampan, 2010-03-20 00:35:09]

http://codereview.chromium.org/1145001/diff/52002/17002
File chrome/browser/views/app_launcher.cc (right):

http://codereview.chromium.org/1145001/diff/52002/17002#newcode179
chrome/browser/views/app_launcher.cc:179: font = font.DeriveFont(3);
On 2010/03/19 22:57:00, sky wrote:
> Make 3 a constant.

Done.

http://codereview.chromium.org/1145001/diff/52002/17002#newcode189
chrome/browser/views/app_launcher.cc:189: autocomplete_view->SetUserText(L"");
On 2010/03/19 22:57:00, sky wrote:
> std::wstring

Done.

http://codereview.chromium.org/1145001/diff/52002/17002#newcode414
chrome/browser/views/app_launcher.cc:414: return NULL;
On 2010/03/19 22:57:00, sky wrote:
> If you enter this if, you leak app_launcher.

Doh!
Now deleting.

http://codereview.chromium.org/1145001/diff/52002/17002#newcode425
chrome/browser/views/app_launcher.cc:425: gtk_widget_realize(rwhv_widget);
On 2010/03/19 22:57:00, sky wrote:
> A comment as to why this is needed would be nice.

Actually I just copied that code from what was there already, but looks like we
don't need to do that. (the rwhv displays just fine on Linux without it).
Removed.

http://codereview.chromium.org/1145001/diff/52002/17002#newcode496
chrome/browser/views/app_launcher.cc:496: pending_contents_.reset(NULL);
On 2010/03/19 22:57:00, sky wrote:
> Do you really need to do either of these things? Won't it be handled for you
by
> way of delete this?

You are right. Thinking about it, I don't event need the Cleanup method and
factory, I can just use a DeleteTask.

[sky, 2010-03-22 15:46:49]

LGTM