Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 118028: Implements a Zip() utility function. Refactor existing (Closed)

Created:
11 years, 6 months ago by Aaron Boodman
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Implements a Zip() utility function. Refactor existing Unzip-relatedness into shared locations.

Patch Set 1 #

Patch Set 2 : Attempt to get rietveld to recognize copies #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+539 lines, -565 lines) Patch
M chrome/browser/extensions/extensions_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/common.vcproj View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/common/extensions/extension_unpacker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/unzip.h View 1 chunk +0 lines, -19 lines 0 comments Download
M chrome/common/unzip.cc View 1 chunk +0 lines, -200 lines 0 comments Download
M chrome/common/unzip_unittest.cc View 1 chunk +0 lines, -93 lines 0 comments Download
A chrome/common/zip.h View 1 chunk +23 lines, -0 lines 1 comment Download
A chrome/common/zip.cc View 1 chunk +293 lines, -0 lines 0 comments Download
A chrome/common/zip_unittest.cc View 1 chunk +131 lines, -0 lines 1 comment Download
M chrome/test/data/unzip/test.zip View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/test/data/unzip/test/foo.txt View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/unzip/test/foo/bar.txt View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/unzip/test/foo/bar/baz.txt View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/unzip/test/foo/bar/quux.txt View 1 chunk +0 lines, -39 lines 0 comments Download
M chrome/test/data/unzip/test_nocompress.zip View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/zip/test.zip View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/zip/test/foo.txt View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/zip/test/foo/bar.txt View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/zip/test/foo/bar/baz.txt View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/zip/test/foo/bar/quux.txt View 1 chunk +39 lines, -0 lines 0 comments Download
A chrome/test/data/zip/test_nocompress.zip View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/test/unit/unittests.vcproj View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/memory_watcher/memory_watcher.vcproj View 1 chunk +41 lines, -202 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Aaron Boodman
Sorry about the lack of correct formatting of copies in the patch. I tried for ...
11 years, 6 months ago (2009-05-29 22:58:27 UTC) #1
Erik does not do reviews
11 years, 6 months ago (2009-05-29 23:33:27 UTC) #2
LGTM - just add a TODO for the other test

http://codereview.chromium.org/118028/diff/1024/1032
File chrome/common/zip.h (right):

http://codereview.chromium.org/118028/diff/1024/1032#newcode13
Line 13: // directory. If it is a directory, it will be zipped recursively.
note that on failure a partial zip file may still exist and needs to be cleaned
up by the caller.

http://codereview.chromium.org/118028/diff/1024/1033
File chrome/common/zip_unittest.cc (right):

http://codereview.chromium.org/118028/diff/1024/1033#newcode124
Line 124: ASSERT_TRUE(Zip(src_dir, zip_file));
we should do a zip then unzip verification test

http://codereview.chromium.org/118028/diff/1024/1047
File tools/memory_watcher/memory_watcher.vcproj (right):

http://codereview.chromium.org/118028/diff/1024/1047#newcode2
Line 2: <VisualStudioProject Keyword="Win32Proj" Name="memory_watcher"
ProjectGUID="{3BD81303-4E14-4559-AA69-B30C3BAB08DD}" ProjectType="Visual C++"
RootNamespace="memory_watcher" Version="8.00">
this diff seems unintentional

Powered by Google App Engine
This is Rietveld 408576698