Issue 118054: Address post-lgtm comment from Evan. No functionality change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 118054: Address post-lgtm comment from Evan. No functionality change. (Closed)

Created:
11 years, 6 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
TVL, Evan Martin

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Address post-lgtm comment from Evan. No functionality change. BUG=none TEST=none TBR=evanm Review URL: http://codereview.chromium.org/118054 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17299

Patch Set 2 : '' #

Total comments: 2

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/browser.cc	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

TVL

http://codereview.chromium.org/118054/diff/1001/5 File chrome/browser/browser.cc (right): http://codereview.chromium.org/118054/diff/1001/5#newcode284 Line 284: #if !(defined(OS_LINUX) && defined(TOOLKIT_VIEWS)) drive by:: seems like ...

11 years, 6 months ago (2009-06-01 00:41:43 UTC) #2