Issue 12770031: Move AppIsolation out of Extension Class

Issue 12770031: Move AppIsolation out of Extension Class (Closed)

Created:
7 years, 9 months ago by Devlin

Modified:
7 years, 8 months ago

Reviewers:
Yoyo Zhou, Ben Goodger (Google), Jói

CC:
chromium-reviews, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, jam, chromium-apps-reviews_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Move AppIsolation out of Extension Class [email protected], [email protected] (ben - gypis, joi - public/browser/ comment update) BUG=159265 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191571

Patch Set 3 : Latest master for CQ #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+192 lines, -68 lines)			Patch
M	chrome/browser/chrome_content_browser_client.cc	View		4 chunks	+7 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/chrome_manifest_parser.cc	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_service.cc	View		4 chunks	+8 lines, -5 lines	0 comments	Download
M	chrome/chrome_common.gypi	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension.h	View	1 2	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	1 2	3 chunks	+0 lines, -46 lines	0 comments	Download
M	chrome/common/extensions/extension_process_policy.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
A	chrome/common/extensions/manifest_handlers/app_isolation_info.h	View	1 2	1 chunk	+44 lines, -0 lines	0 comments	Download
A	chrome/common/extensions/manifest_handlers/app_isolation_info.cc	View	1 2	1 chunk	+98 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/manifest_tests/extension_manifests_isolatedapp_unittest.cc	View		1 chunk	+16 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc	View		2 chunks	+7 lines, -3 lines	0 comments	Download
M	chrome/renderer/chrome_content_renderer_client.cc	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	content/public/browser/browser_context.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Yoyo Zhou

LGTM https://codereview.chromium.org/12770031/diff/11001/chrome/common/extensions/manifest_handlers/app_isolation_info.cc File chrome/common/extensions/manifest_handlers/app_isolation_info.cc (right): https://codereview.chromium.org/12770031/diff/11001/chrome/common/extensions/manifest_handlers/app_isolation_info.cc#newcode50 chrome/common/extensions/manifest_handlers/app_isolation_info.cc:50: || !extension->is_app()) { nit: || belongs at the ...

7 years, 9 months ago (2013-03-29 01:14:03 UTC) #2

Devlin

https://codereview.chromium.org/12770031/diff/11001/chrome/common/extensions/manifest_handlers/app_isolation_info.cc File chrome/common/extensions/manifest_handlers/app_isolation_info.cc (right): https://codereview.chromium.org/12770031/diff/11001/chrome/common/extensions/manifest_handlers/app_isolation_info.cc#newcode50 chrome/common/extensions/manifest_handlers/app_isolation_info.cc:50: || !extension->is_app()) { On 2013/03/29 01:14:03, Yoyo Zhou wrote: ...

7 years, 8 months ago (2013-03-31 01:29:55 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/12770031/21001

7 years, 8 months ago (2013-03-31 01:30:47 UTC) #4

Message was sent while issue was closed.

Change committed as 191571

Expand Messages | Collapse Messages