Add support for branded strings into //components/strings.

Add support for branded strings into //components/strings.

Add two new files components_{chromium,google_chrome}_strings.grd into
stc/components and their empty .xtb files. Those files will hold branded
strings for the components (i.e. strings that reference the product,
see http://goo.gl/6614MQ).

Update repack steps to also pack those localizations too.

BUG=523362
Committed: https://crrev.com/b87a3c7be58e77b9c53fde1c0a138de0b89285d2
Cr-Commit-Position: refs/heads/master@{#346891}

[sdefresne, 2015-08-26 09:56:47]

[email protected] changed reviewers:
+ [email protected], [email protected], [email protected],
[email protected]

[sdefresne, 2015-08-26 09:56:48]

Please take a look.

[sdefresne, 2015-08-26 09:59:04]

Patchset #1 (id:1) has been deleted

[newt (away), 2015-08-26 21:28:45]

It is OK for components/ to reference "Chrome", even though components/ sits
below the chrome/ layer? I think a components/ OWNER should OK this decision.

https://codereview.chromium.org/1307223005/diff/20001/components/strings/BUIL...
File components/strings/BUILD.gn (right):

https://codereview.chromium.org/1307223005/diff/20001/components/strings/BUIL...
components/strings/BUILD.gn:96: "components_chromium_strings_am.pak",
We should really extract the list of languages into a GN variable, instead of
listing these out all the time and duplicating the ios-specific language
differences.

https://codereview.chromium.org/1307223005/diff/20001/tools/gritsettings/reso...
File tools/gritsettings/resource_ids (right):

https://codereview.chromium.org/1307223005/diff/20001/tools/gritsettings/reso...
tools/gritsettings/resource_ids:265: "messages": [30270],
Doesn't seem like enough space.

[blundell, 2015-08-27 08:21:53]

On 2015/08/26 21:28:45, newt wrote:
> It is OK for components/ to reference "Chrome", even though components/ sits
> below the chrome/ layer? I think a components/ OWNER should OK this decision.
> 

This is OK (also, Sylvain is a //components OWNER himself ;). The intent here is
to allow sharing code between //ios and //chrome which is Chrome-specific. This
chromium-dev@ thread ends up concluding that that's a valid reason for having a
component, although the thread is somewhat long and tangled:
https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/QehRp_X9vkI...

At the risk of losing context, here's the most important quote in that thread
from jam@:

"Colin's intent is that code would move from chrome to components if it's needed
by iOS. That includes code which talks to Google services, or does something
which is only used for Google Chrome and not Chromium builds. I'm saying that we
don't add any restrictions for moving this code to src\components."
 
>
https://codereview.chromium.org/1307223005/diff/20001/components/strings/BUIL...
> File components/strings/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1307223005/diff/20001/components/strings/BUIL...
> components/strings/BUILD.gn:96: "components_chromium_strings_am.pak",
> We should really extract the list of languages into a GN variable, instead of
> listing these out all the time and duplicating the ios-specific language
> differences.
> 
>
https://codereview.chromium.org/1307223005/diff/20001/tools/gritsettings/reso...
> File tools/gritsettings/resource_ids (right):
> 
>
https://codereview.chromium.org/1307223005/diff/20001/tools/gritsettings/reso...
> tools/gritsettings/resource_ids:265: "messages": [30270],
> Doesn't seem like enough space.

[blundell, 2015-08-27 08:22:44]

Sylvain,

What would you like the various reviewers to focus on in this CL?

[sdefresne, 2015-08-27 09:49:53]

blundell: can you look at the .gyp and .gn changes?

amineer/newt/tinazh: can one of you look at the .grd, .xtb and
tools/gritsettings/resource_ids?

https://codereview.chromium.org/1307223005/diff/20001/components/strings/BUIL...
File components/strings/BUILD.gn (right):

https://codereview.chromium.org/1307223005/diff/20001/components/strings/BUIL...
components/strings/BUILD.gn:96: "components_chromium_strings_am.pak",
On 2015/08/26 at 21:28:45, newt wrote:
> We should really extract the list of languages into a GN variable, instead of
listing these out all the time and duplicating the ios-specific language
differences.

Agreed. Filed https://code.google.com/p/chromium/issues/detail?id=525492 to
track this.

https://codereview.chromium.org/1307223005/diff/20001/tools/gritsettings/reso...
File tools/gritsettings/resource_ids (right):

https://codereview.chromium.org/1307223005/diff/20001/tools/gritsettings/reso...
tools/gritsettings/resource_ids:265: "messages": [30270],
On 2015/08/26 at 21:28:45, newt wrote:
> Doesn't seem like enough space.

I'm planning to add only a few strings (currently only four) and
components_strings.grd is almost constantly generating duplicate IDs with
components_resources.grd (i.e. the correct thing to do would be to decrement
chrome/app/generated_resources.grd by the number of strings that have been moved
to components/components_strings.grd and increment it by that much.

My plan it do this balancing in a followup CL (the one were I'll move the
strings to componentize).

[blundell, 2015-08-27 09:56:04]

lgtm

[sdefresne, 2015-08-27 10:17:03]

On 2015/08/27 at 09:56:04, blundell wrote:
> lgtm

Thank you, but I found that I had uncommitted changes that are needed in that
CL, can you review the following updated files:
    chrome/chrome_repack_locales.gni
    chrome/tools/build/repack_locales.py
    ios/chrome/tools/build/ios_repack_locales.py

[blundell, 2015-08-27 12:42:46]

lgtm

[newt (away), 2015-08-27 16:55:21]

everything lgtm after comments

https://codereview.chromium.org/1307223005/diff/40001/chrome/tools/build/repa...
File chrome/tools/build/repack_locales.py (right):

https://codereview.chromium.org/1307223005/diff/40001/chrome/tools/build/repa...
chrome/tools/build/repack_locales.py:87: #
components_<(BRANDING)_strings_da.pak',
Shouldn't this *example* just say "google_chrome" or "chromium" instead of
"<(BRANDING)"? Seems more helpful to a reader than just repeating the path
concatenation that's happening below.

https://codereview.chromium.org/1307223005/diff/40001/components/components_c...
File components/components_chromium_strings.grd (right):

https://codereview.chromium.org/1307223005/diff/40001/components/components_c...
components/components_chromium_strings.grd:134: <messages
fallback_to_english="true">
I'd suggest adding at least one string here so we can be convinced that the
build changes are actually working.

[sdefresne, 2015-09-01 17:30:02]

[email protected] changed reviewers:
+ [email protected]
- [email protected], [email protected]

[sdefresne, 2015-09-01 17:30:03]

Thank you for the review.

sky: can you review changes to //chrome as OWNERS?

https://codereview.chromium.org/1307223005/diff/40001/chrome/tools/build/repa...
File chrome/tools/build/repack_locales.py (right):

https://codereview.chromium.org/1307223005/diff/40001/chrome/tools/build/repa...
chrome/tools/build/repack_locales.py:87: #
components_<(BRANDING)_strings_da.pak',
On 2015/08/27 at 16:55:21, newt wrote:
> Shouldn't this *example* just say "google_chrome" or "chromium" instead of
"<(BRANDING)"? Seems more helpful to a reader than just repeating the path
concatenation that's happening below.

Done.

https://codereview.chromium.org/1307223005/diff/40001/components/components_c...
File components/components_chromium_strings.grd (right):

https://codereview.chromium.org/1307223005/diff/40001/components/components_c...
components/components_chromium_strings.grd:134: <messages
fallback_to_english="true">
On 2015/08/27 at 16:55:21, newt wrote:
> I'd suggest adding at least one string here so we can be convinced that the
build changes are actually working.

Done.

[sky, 2015-09-01 19:44:59]

LGTM

[sdefresne, 2015-09-02 10:36:07]

The CQ bit was checked by [email protected]

[sdefresne, 2015-09-02 10:36:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
[email protected], [email protected]
Link to the patchset: https://codereview.chromium.org/1307223005/#ps60001
(title: "Rebase & move IDS_ERRORPAGES_SUGGESTION_NETWORK_PREDICTION_BODY to
//components/components_*_string…")

[commit-bot: I haz the power, 2015-09-02 10:36:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1307223005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1307223005/60001

[commit-bot: I haz the power, 2015-09-02 11:50:58]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-09-02 11:51:38]

Patchset 3 (id:??) landed as
https://crrev.com/b87a3c7be58e77b9c53fde1c0a138de0b89285d2
Cr-Commit-Position: refs/heads/master@{#346891}