Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 1314803004: Move chrome/browser/chromeos/drive/file_system.cc (+deps) into components/drive. (Closed)

Created:
5 years, 3 months ago by Łukasz Anforowicz
Modified:
5 years, 3 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org, zea+watch_chromium.org, tzik, tfarina, maxbogue+watch_chromium.org, nhiroki, pvalenzuela+watch_chromium.org, rginda+watch_chromium.org, plaree+watch_chromium.org, oshima+watch_chromium.org, blundell+watchlist_chromium.org, chromium-apps-reviews_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move chrome/browser/chromeos/drive/file_system.cc (+deps) into components/drive. Previous CL (crrev.com/1318543003) has moved the chrome/browser/chromeos/drive/file_system/ directory (and its dependencies) into components/drive. This CL moves chrome/browser/chromeos/drive/file_system.cc file (and its dependencies) into components/drive. Files moved from chrome/browser/chromeos/drive into components/drive: - directory_loader* - dummy_file_system* - fake_file_system* - file_system* - file_system_observer.h - remove_stale_cache_files* - search_metadata* - sync/* - sync_client* Test steps: 1. Verify that things still build via GYP. $ GYP_DEFINES="use_goma=1 chromeos=1 component=shared_library" gclient sync $ ninja -C out/Debug -j 150 chrome unit_tests \ interactive_ui_tests browser_tests drive 2. Verify that things still build via GN. $ gn gen out/Default --args='target_os="chromeos" use_goma=true is_component_build=true' $ ninja -C out/Default -j 150 chrome unit_tests \ interactive_ui_tests browser_tests components/drive TEST=Please see "Test steps" above. BUG=257943, 498951 Committed: https://crrev.com/2e964692340581cc6349a334d0f8ebbe601944df Cr-Commit-Position: refs/heads/master@{#346429}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebasing... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -8952 lines) Patch
D chrome/browser/chromeos/drive/directory_loader.h View 1 chunk +0 lines, -150 lines 0 comments Download
D chrome/browser/chromeos/drive/directory_loader.cc View 1 chunk +0 lines, -571 lines 0 comments Download
D chrome/browser/chromeos/drive/directory_loader_unittest.cc View 1 chunk +0 lines, -252 lines 0 comments Download
M chrome/browser/chromeos/drive/download_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/drive_file_stream_reader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/drive_integration_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/drive_integration_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/drive/dummy_file_system.h View 1 chunk +0 lines, -111 lines 0 comments Download
D chrome/browser/chromeos/drive/dummy_file_system.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/browser/chromeos/drive/fake_file_system.h View 1 chunk +0 lines, -197 lines 0 comments Download
D chrome/browser/chromeos/drive/fake_file_system.cc View 1 chunk +0 lines, -420 lines 0 comments Download
D chrome/browser/chromeos/drive/fake_file_system_unittest.cc View 1 chunk +0 lines, -156 lines 0 comments Download
D chrome/browser/chromeos/drive/file_system.h View 1 chunk +0 lines, -311 lines 0 comments Download
D chrome/browser/chromeos/drive/file_system.cc View 1 chunk +0 lines, -1060 lines 0 comments Download
D chrome/browser/chromeos/drive/file_system_observer.h View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/browser/chromeos/drive/file_system_unittest.cc View 1 chunk +0 lines, -1064 lines 0 comments Download
M chrome/browser/chromeos/drive/file_task_executor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/fileapi/fileapi_worker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/fileapi/webkit_file_stream_reader_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/drive/remove_stale_cache_files.h View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/browser/chromeos/drive/remove_stale_cache_files.cc View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/chromeos/drive/remove_stale_cache_files_unittest.cc View 1 chunk +0 lines, -115 lines 0 comments Download
D chrome/browser/chromeos/drive/search_metadata.h View 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/browser/chromeos/drive/search_metadata.cc View 1 chunk +0 lines, -335 lines 0 comments Download
D chrome/browser/chromeos/drive/search_metadata_unittest.cc View 1 chunk +0 lines, -500 lines 0 comments Download
D chrome/browser/chromeos/drive/sync/entry_revert_performer.h View 1 chunk +0 lines, -93 lines 0 comments Download
D chrome/browser/chromeos/drive/sync/entry_revert_performer.cc View 1 chunk +0 lines, -178 lines 0 comments Download
D chrome/browser/chromeos/drive/sync/entry_revert_performer_unittest.cc View 1 chunk +0 lines, -151 lines 0 comments Download
D chrome/browser/chromeos/drive/sync/entry_update_performer.h View 1 chunk +0 lines, -106 lines 0 comments Download
D chrome/browser/chromeos/drive/sync/entry_update_performer.cc View 1 chunk +0 lines, -450 lines 0 comments Download
D chrome/browser/chromeos/drive/sync/entry_update_performer_unittest.cc View 1 chunk +0 lines, -658 lines 0 comments Download
D chrome/browser/chromeos/drive/sync/remove_performer.h View 1 chunk +0 lines, -114 lines 0 comments Download
D chrome/browser/chromeos/drive/sync/remove_performer.cc View 1 chunk +0 lines, -255 lines 0 comments Download
D chrome/browser/chromeos/drive/sync/remove_performer_unittest.cc View 1 chunk +0 lines, -199 lines 0 comments Download
D chrome/browser/chromeos/drive/sync_client.h View 1 chunk +0 lines, -199 lines 0 comments Download
D chrome/browser/chromeos/drive/sync_client.cc View 1 chunk +0 lines, -491 lines 0 comments Download
D chrome/browser/chromeos/drive/sync_client_unittest.cc View 1 chunk +0 lines, -523 lines 0 comments Download
M chrome/browser/chromeos/drive/write_on_cache_file_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/event_router.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_manager/fileapi_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/fileapi/external_file_url_request_job_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 2 chunks +0 lines, -17 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 chunks +9 lines, -13 lines 0 comments Download
M components/drive.gypi View 5 chunks +21 lines, -0 lines 0 comments Download
M components/drive/BUILD.gn View 5 chunks +21 lines, -0 lines 0 comments Download
M components/drive/DEPS View 2 chunks +20 lines, -9 lines 0 comments Download
A + components/drive/directory_loader.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/drive/directory_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/drive/directory_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/drive/dummy_file_system.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/drive/dummy_file_system.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/drive/fake_file_system.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/drive/fake_file_system.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/drive/fake_file_system_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/drive/file_system.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/drive/file_system.cc View 2 chunks +6 lines, -6 lines 0 comments Download
A + components/drive/file_system_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/drive/file_system_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + components/drive/remove_stale_cache_files.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/drive/remove_stale_cache_files.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/drive/remove_stale_cache_files_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/drive/search_metadata.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/drive/search_metadata.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/drive/search_metadata_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/drive/sync/entry_revert_performer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/drive/sync/entry_revert_performer.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/drive/sync/entry_revert_performer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/drive/sync/entry_update_performer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/drive/sync/entry_update_performer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/drive/sync/entry_update_performer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/drive/sync/remove_performer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/drive/sync/remove_performer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/drive/sync/remove_performer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/drive/sync_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/drive/sync_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/drive/sync_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Łukasz Anforowicz
Tomasz, could you please take a look?
5 years, 3 months ago (2015-08-28 22:59:54 UTC) #2
mtomasz
lgtm, awesome!
5 years, 3 months ago (2015-08-31 06:10:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314803004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314803004/40001
5 years, 3 months ago (2015-08-31 17:33:44 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-08-31 18:57:30 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 18:58:06 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2e964692340581cc6349a334d0f8ebbe601944df
Cr-Commit-Position: refs/heads/master@{#346429}

Powered by Google App Engine
This is Rietveld 408576698