Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1389073002: [NTP] Change the include condition on local_files_ntp_source to be !is_chrome_branded (Closed)

Created:
5 years, 2 months ago by Mathieu
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP] Change the include condition on local_files_ntp_source to be !is_chrome_branded BUG=515743 TBR=thestig Committed: https://crrev.com/17e1eba28979d8e810ece0f193e5a0ad14104cf9 Cr-Commit-Position: refs/heads/master@{#352694}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Sébastien Marchand
lgtm, lets wait to see if the "Compile: Instrumentation phase." step of the PGO build ...
5 years, 2 months ago (2015-10-06 20:41:41 UTC) #2
Mathieu
Sure, in the meantime I've TBR'ed thestig@ for the GN change.
5 years, 2 months ago (2015-10-06 20:43:20 UTC) #4
Lei Zhang
lgtm
5 years, 2 months ago (2015-10-06 20:48:07 UTC) #5
Sébastien Marchand
browser*.lib has linked successfully, it's OK to flip the CQ bit now.
5 years, 2 months ago (2015-10-06 21:42:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1389073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1389073002/1
5 years, 2 months ago (2015-10-06 21:43:59 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-06 21:51:12 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 21:52:07 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17e1eba28979d8e810ece0f193e5a0ad14104cf9
Cr-Commit-Position: refs/heads/master@{#352694}

Powered by Google App Engine
This is Rietveld 408576698