Remove ability for users to launch ephemeral apps.

Remove ability for users to launch ephemeral apps.

Test code can still do this.

BUG=517735
Committed: https://crrev.com/cb4422c1ee7c1909afed5edbce2cbc3dcaaea80a
Cr-Commit-Position: refs/heads/master@{#353904}

[benwells, 2015-10-11 22:00:36]

[email protected] changed reviewers:
+ [email protected]

[benwells, 2015-10-11 22:00:37]

Next steps:
- remove all ephemeral apps from cache at startup and update tests
- wait a milestone
- remove the rest of the code

[Devlin, 2015-10-12 16:02:56]

On 2015/10/11 22:00:37, benwells wrote:
> Next steps:
> - remove all ephemeral apps from cache at startup and update tests
> - wait a milestone
> - remove the rest of the code

LGTM.  Since test code can still do this, I'm assuming that the following (and
branches from them) are still needed:
CRXInstaller::set_is_ephemeral()
ExtensionPrefs::IsEphemeralApp()
kInstallFlagIsEphemeral

(If that's a bad assumption, let's take those out, too.)

[benwells, 2015-10-13 03:29:01]

On 2015/10/12 16:02:56, Devlin wrote:
> On 2015/10/11 22:00:37, benwells wrote:
> > Next steps:
> > - remove all ephemeral apps from cache at startup and update tests
> > - wait a milestone
> > - remove the rest of the code
> 
> LGTM.  Since test code can still do this, I'm assuming that the following (and
> branches from them) are still needed:
> CRXInstaller::set_is_ephemeral()
> ExtensionPrefs::IsEphemeralApp()
> kInstallFlagIsEphemeral
> 
> (If that's a bad assumption, let's take those out, too.)

That assumption is right. There is substantial code in the extension system
which deals with purging data for ephemeral apps. My plan is to leave this in
place for a milestone, but to change the constants so they are removed
immediately (instead of kept for 30 days or whatever it is currently).

The code left is the minimum (i think) required to have that system there, and
to have it continue to be tested.

[benwells, 2015-10-13 03:29:26]

[email protected] changed reviewers:
+ [email protected]

[benwells, 2015-10-13 03:29:27]

+isherman for histograms

[Ilya Sherman, 2015-10-13 18:54:02]

histograms.xml lgtm

[benwells, 2015-10-13 22:07:12]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2015-10-13 22:13:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1395043002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1395043002/1

[commit-bot: I haz the power, 2015-10-13 23:39:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-13 23:39:47]

Patchset 1 (id:??) landed as
https://crrev.com/cb4422c1ee7c1909afed5edbce2cbc3dcaaea80a
Cr-Commit-Position: refs/heads/master@{#353904}