Issue 15060002: drive: Rename FileCache methods in a blocking pool centric manner

Issue 15060002: drive: Rename FileCache methods in a blocking pool centric manner (Closed)

Created:
7 years, 7 months ago by hashimoto

Modified:
7 years, 7 months ago

Reviewers:
hidehiko

CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, oshima+watch_chromium.org, tzik+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Rename FileCache methods in a blocking pool centric manner BUG=231221 TEST=build [email protected] Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199168

Patch Set 3 : remove virtual #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+418 lines, -379 lines)			Patch
M	chrome/browser/chromeos/drive/debug_info_collector.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/drive/drive_system_service.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/drive/file_cache.h	View	1 2	9 chunks	+117 lines, -98 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_cache.cc	View		26 chunks	+94 lines, -99 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_cache_unittest.cc	View		21 chunks	+43 lines, -36 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system.cc	View	1	17 chunks	+37 lines, -36 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/copy_operation.cc	View	1	1 chunk	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/remove_operation.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/update_operation.cc	View	1	2 chunks	+12 lines, -11 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system_unittest.cc	View	1	10 chunks	+50 lines, -46 lines	0 comments	Download
M	chrome/browser/chromeos/drive/stale_cache_files_remover.cc	View		3 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/drive/stale_cache_files_remover_unittest.cc	View		2 chunks	+10 lines, -9 lines	0 comments	Download
M	chrome/browser/chromeos/drive/sync_client.cc	View		3 chunks	+15 lines, -15 lines	0 comments	Download
M	chrome/browser/chromeos/drive/sync_client_unittest.cc	View		1 chunk	+25 lines, -18 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

hidehiko

lgtm https://codereview.chromium.org/15060002/diff/5001/chrome/browser/chromeos/drive/file_cache.h File chrome/browser/chromeos/drive/file_cache.h (right): https://codereview.chromium.org/15060002/diff/5001/chrome/browser/chromeos/drive/file_cache.h#newcode299 chrome/browser/chromeos/drive/file_cache.h:299: virtual ~FileCache(); off topic nit: s/virtual//

7 years, 7 months ago (2013-05-09 06:41:04 UTC) #2

hashimoto

https://codereview.chromium.org/15060002/diff/5001/chrome/browser/chromeos/drive/file_cache.h File chrome/browser/chromeos/drive/file_cache.h (right): https://codereview.chromium.org/15060002/diff/5001/chrome/browser/chromeos/drive/file_cache.h#newcode299 chrome/browser/chromeos/drive/file_cache.h:299: virtual ~FileCache(); On 2013/05/09 06:41:04, hidehiko wrote: > off ...

7 years, 7 months ago (2013-05-09 07:13:44 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/15060002/2002

7 years, 7 months ago (2013-05-09 07:13:56 UTC) #4

commit-bot: I haz the power

Retried try job too often on ios_dbg_simulator for step(s) googleurl_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=50859

7 years, 7 months ago (2013-05-09 07:36:18 UTC) #5

hashimoto

7 years, 7 months ago (2013-05-09 08:43:59 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r199168 (presubmit successful).

Expand Messages | Collapse Messages