Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 152223002: Renames LauncherID, LauncherItem and LauncherItems... (Closed)

Created:
6 years, 10 months ago by tfarina
Modified:
6 years, 10 months ago
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Renames LauncherID, LauncherItem and LauncherItems... to ShelfID, ShelfItem and ShelfItems. BUG=248353 TEST=None [email protected],[email protected] Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248619

Patch Set 1 #

Patch Set 2 : ShelfID #

Patch Set 3 : ShelfItem #

Patch Set 4 : rm launcher_types.* #

Patch Set 5 : OWNERS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+760 lines, -815 lines) Patch
M ash/ash.gyp View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
D ash/launcher/OWNERS View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M ash/launcher/launcher_types.h View 1 2 3 1 chunk +0 lines, -38 lines 0 comments Download
M ash/launcher/launcher_types.cc View 1 2 3 1 chunk +0 lines, -20 lines 0 comments Download
M ash/shelf/OWNERS View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M ash/shelf/alternate_app_list_button.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/app_list_shelf_item_delegate.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M ash/shelf/shelf_button.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M ash/shelf/shelf_delegate.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M ash/shelf/shelf_item_delegate.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_item_delegate_manager.h View 1 2 3 2 chunks +8 lines, -8 lines 0 comments Download
M ash/shelf/shelf_item_delegate_manager.cc View 1 2 4 chunks +6 lines, -7 lines 0 comments Download
M ash/shelf/shelf_item_types.h View 1 2 3 2 chunks +23 lines, -0 lines 0 comments Download
M ash/shelf/shelf_item_types.cc View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M ash/shelf/shelf_model.h View 1 2 3 5 chunks +11 lines, -11 lines 0 comments Download
M ash/shelf/shelf_model.cc View 1 2 8 chunks +16 lines, -16 lines 0 comments Download
M ash/shelf/shelf_model_observer.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M ash/shelf/shelf_model_unittest.cc View 1 2 12 chunks +20 lines, -20 lines 0 comments Download
M ash/shelf/shelf_navigator.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ash/shelf/shelf_navigator_unittest.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M ash/shelf/shelf_unittest.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M ash/shelf/shelf_util.h View 1 2 3 2 chunks +6 lines, -7 lines 0 comments Download
M ash/shelf/shelf_util.cc View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
M ash/shelf/shelf_view.h View 1 2 8 chunks +11 lines, -11 lines 0 comments Download
M ash/shelf/shelf_view.cc View 1 2 21 chunks +31 lines, -34 lines 0 comments Download
M ash/shelf/shelf_view_unittest.cc View 1 2 34 chunks +73 lines, -73 lines 0 comments Download
M ash/shelf/shelf_window_watcher.h View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M ash/shelf/shelf_window_watcher.cc View 1 2 10 chunks +38 lines, -39 lines 0 comments Download
M ash/shelf/shelf_window_watcher_item_delegate.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M ash/shelf/shelf_window_watcher_unittest.cc View 1 2 3 9 chunks +26 lines, -26 lines 0 comments Download
M ash/shell.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/app_list.cc View 1 2 8 chunks +19 lines, -23 lines 0 comments Download
M ash/shell/shelf_delegate_impl.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shell/shelf_delegate_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shell/shell_delegate_impl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/window_watcher.h View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M ash/shell/window_watcher.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M ash/shell/window_watcher_shelf_item_delegate.h View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M ash/shell/window_watcher_shelf_item_delegate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/shell_delegate.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ash/test/test_shelf_delegate.h View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M ash/test/test_shelf_delegate.cc View 1 2 5 chunks +13 lines, -13 lines 0 comments Download
M ash/test/test_shell_delegate.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_shell_delegate.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/dock/docked_window_layout_manager_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/dock/docked_window_resizer_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 1 2 7 chunks +8 lines, -9 lines 0 comments Download
M ash/wm/panels/panel_window_resizer_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/workspace_controller_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/launcher/browser_status_monitor.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/browser_status_monitor.cc View 1 4 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.h View 1 2 3 14 chunks +41 lines, -46 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 2 54 chunks +102 lines, -105 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 1 2 41 chunks +70 lines, -70 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 1 2 31 chunks +47 lines, -49 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu.h View 1 2 3 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu.cc View 1 2 4 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_item_controller.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_item_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_item_util.cc View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/shell_window_launcher_controller.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/shell_window_launcher_controller.cc View 1 6 chunks +46 lines, -46 lines 0 comments Download
M chrome/browser/ui/ash/launcher/shell_window_launcher_item_controller.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/shell_window_launcher_item_controller.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
tfarina
Another Sunday, another patch. And ash/launcher is gone.
6 years, 10 months ago (2014-02-02 17:27:53 UTC) #1
James Cook
I'll take a look after harry.
6 years, 10 months ago (2014-02-03 19:30:16 UTC) #2
Harry McCleave
On 2014/02/03 19:30:16, James Cook wrote: > I'll take a look after harry. lgtm, thank ...
6 years, 10 months ago (2014-02-03 20:39:08 UTC) #3
James Cook
LGTM! Thanks again.
6 years, 10 months ago (2014-02-03 20:55:41 UTC) #4
tfarina
The CQ bit was checked by [email protected]
6 years, 10 months ago (2014-02-03 21:22:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/152223002/170001
6 years, 10 months ago (2014-02-03 21:24:15 UTC) #6
commit-bot: I haz the power
Change committed as 248619
6 years, 10 months ago (2014-02-03 23:51:31 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 23:51:31 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 23:51:34 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 23:51:37 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 23:51:38 UTC) #11
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 23:51:40 UTC) #12
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698