Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 1545803002: Use .rc strings in fewer places for installer util. (Closed)

Created:
5 years ago by brettw
Modified:
4 years, 11 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, extensions-reviews_chromium.org, grt+watch_chromium.org, oshima+watch_chromium.org, wfh+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use .rc strings in fewer places for installer util. The resource strings are needed only for the setup app and unit tests. Previously they were also linked into Chrome. This clarifies the usage and renames the targets to force you to pick (previously the naming encouraged you to link to the strings, which is probably not correct for most cases. Committed: https://crrev.com/e26e6d0a79391734160024bba2955353760c5020 Cr-Commit-Position: refs/heads/master@{#367057}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -43 lines) Patch
M chrome/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metro_utils/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_watcher/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/gcapi/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/setup/BUILD.gn View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/installer/test/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/BUILD.gn View 4 chunks +34 lines, -22 lines 0 comments Download
M chrome/tools/crash_service/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M win8/delegate_execute/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M win8/metro_driver/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
brettw
Follow up from https://codereview.chromium.org/1534903002/
5 years ago (2015-12-22 22:30:52 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1545803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1545803002/1
5 years ago (2015-12-22 22:32:50 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-22 23:07:02 UTC) #7
Dirk Pranke
lgtm. I like this better than the previous version; good to know it was a ...
5 years ago (2015-12-23 03:32:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1545803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1545803002/1
4 years, 12 months ago (2015-12-29 06:12:35 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-29 06:51:57 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2015-12-29 06:52:38 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e26e6d0a79391734160024bba2955353760c5020
Cr-Commit-Position: refs/heads/master@{#367057}

Powered by Google App Engine
This is Rietveld 408576698