Issue 155753: Refactoring of the page info (take 2)

Issue 155753: Refactoring of the page info (take 2) (Closed)

Created:
11 years, 5 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com, John Grabowski, brettw, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Relanding the the refactoring the page info to have a model. BUG=None TEST=Make sure clicking the lock/warning icon when visiting a HTTPS page brings the page info and that it reports the correct info. Also check that the "Page/Frame info" right click menu works as well. TBR=ben Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21065

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+206 lines, -960 lines)			Patch
M	chrome/browser/browser.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/browser.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_prefs.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/browser_window.h	View		2 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/browser_window_cocoa.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/browser_window_cocoa.mm	View		2 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/page_info_window_controller.h	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/cocoa/page_info_window_controller.mm	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/cocoa/page_info_window_mac.h	View		1 chunk	+25 lines, -22 lines	0 comments	Download
M	chrome/browser/cocoa/page_info_window_mac.mm	View		3 chunks	+52 lines, -163 lines	0 comments	Download
M	chrome/browser/gtk/browser_window_gtk.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/browser_window_gtk.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu.cc	View		3 chunks	+5 lines, -22 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents_delegate.h	View		2 chunks	+13 lines, -0 lines	0 comments	Download
M	chrome/browser/views/browser_dialogs.h	View		2 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/views/location_bar_view.cc	View		1 chunk	+3 lines, -7 lines	0 comments	Download
A +	chrome/browser/views/page_info_window_view.cc	View		2 chunks	+4 lines, -1 line	0 comments	Download
D	chrome/browser/views/page_info_window_win.h	View	1	1 chunk	+0 lines, -84 lines	0 comments	Download
D	chrome/browser/views/page_info_window_win.cc	View		1 chunk	+0 lines, -650 lines	0 comments	Download
M	chrome/chrome.gyp	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/test/test_browser_window.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A +	chrome\browser\page_info_model.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome\browser\page_info_model.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download