Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 169003002: ui/app_list: Add git cl format presubmit warning. (Closed)

Created:
6 years, 10 months ago by tfarina
Modified:
6 years, 10 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

ui/app_list: Add git cl format presubmit warning. Upon patch upload 'git cl format' is run on the diff and outputs a warning if the diff has style violations, saving manual review time for coding style. BUG=None TEST=None [email protected] Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251724

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
A + ui/app_list/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
6 years, 10 months ago (2014-02-16 21:22:03 UTC) #1
xiyuan
Should this be in a higher level such as src/ui/ or even src/?
6 years, 10 months ago (2014-02-17 07:49:59 UTC) #2
tfarina
On 2014/02/17 07:49:59, xiyuan wrote: > Should this be in a higher level such as ...
6 years, 10 months ago (2014-02-17 18:07:00 UTC) #3
xiyuan
Okay. LGTM
6 years, 10 months ago (2014-02-17 18:15:06 UTC) #4
tfarina
The CQ bit was checked by [email protected]
6 years, 10 months ago (2014-02-18 02:29:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/169003002/1
6 years, 10 months ago (2014-02-18 02:29:56 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 03:54:17 UTC) #7
Message was sent while issue was closed.
Change committed as 251724

Powered by Google App Engine
This is Rietveld 408576698