Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1792010: Relanding http://codereview.chromium.org/1746009/show... (Closed)

Created:
10 years, 7 months ago by Jay Civelli
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Relanding http://codereview.chromium.org/1746009/show (fixed the ChromeOS build). The app launcher now uses the location bar (instead of the autocomplete edit), so it has "tab to search" and the icons on the left side, Also split location_bar_view.cc so that every inner-class gets its own .h and .cc file. BUG=None TEST=Make sure the location bar works as expected (tab to search, bookmark star, page actions...). Open the app launcher, make sure "tab to search" works as expected. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45957

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -2469 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_focus_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/views/app_launcher.cc View 8 chunks +52 lines, -164 lines 0 comments Download
M chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc View 1 chunk +18 lines, -1 line 0 comments Download
M chrome/browser/views/bookmark_bar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/extensions/extension_installed_bubble.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/go_button.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/views/location_bar/click_handler.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/views/location_bar/click_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/views/location_bar/content_setting_image_view.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/views/location_bar/content_setting_image_view.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/views/location_bar/ev_bubble_view.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/views/location_bar/ev_bubble_view.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/views/location_bar/icon_label_bubble_view.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/views/location_bar/icon_label_bubble_view.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/views/location_bar/keyword_hint_view.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/views/location_bar/keyword_hint_view.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/views/location_bar/location_bar_view.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/views/location_bar/location_bar_view.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/views/location_bar/location_icon_view.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/views/location_bar/location_icon_view.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/views/location_bar/page_action_image_view.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/views/location_bar/page_action_image_view.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/views/location_bar/page_action_with_badge_view.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/views/location_bar/page_action_with_badge_view.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/views/location_bar/selected_keyword_view.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/views/location_bar/selected_keyword_view.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/views/location_bar/star_view.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/views/location_bar/star_view.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/views/location_bar_view.h View 1 chunk +0 lines, -645 lines 0 comments Download
D chrome/browser/views/location_bar_view.cc View 1 chunk +0 lines, -1668 lines 0 comments Download
M chrome/browser/views/toolbar_view.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/views/toolbar_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +44 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698