Enable InstanceID field trial by default

Enable InstanceID field trial by default

This makes it easier to write tests, since each test doesn't have to
enable the field trial (which is especially hard from Java).

Part of a series of patches:
1. https://codereview.chromium.org/1832833002 adds InstanceIDWithSubtype
2. https://codereview.chromium.org/1830983002 adds JNI bindings
3. https://codereview.chromium.org/1829023002 adds fake and test
4. https://codereview.chromium.org/1899753002 fixes strict mode violations
5. this patch
6. https://codereview.chromium.org/1923953002 adds crypto integration
7. https://codereview.chromium.org/1851423003 switches Push to InstanceIDs

BUG=589461, 477084
Committed: https://crrev.com/384d15da99c3e9460ee87016aeb6f3387f20dc98
Cr-Commit-Position: refs/heads/master@{#390339}

[johnme, 2016-04-04 11:27:25]

Description was changed from

==========
Enable InstanceID field trial by default

This makes it easier to write tests, since each test doesn't have to
enable the field trial (which is especially hard from Java).

BUG=589461
==========

to

==========
Enable InstanceID field trial by default

This makes it easier to write tests, since each test doesn't have to
enable the field trial (which is especially hard from Java).

BUG=589461, 477084
==========

[johnme, 2016-04-04 12:19:35]

Description was changed from

==========
Enable InstanceID field trial by default

This makes it easier to write tests, since each test doesn't have to
enable the field trial (which is especially hard from Java).

BUG=589461, 477084
==========

to

==========
Enable InstanceID field trial by default

This makes it easier to write tests, since each test doesn't have to
enable the field trial (which is especially hard from Java).

Part of a series of patches:
1. https://codereview.chromium.org/1832833002 adds InstanceIDWithSubtype
2. https://codereview.chromium.org/1830983002 adds JNI bindings
3. https://codereview.chromium.org/1829023002 adds fake and test
4. this patch
5. https://codereview.chromium.org/1851423003 switches Push to InstanceIDs

BUG=589461, 477084
==========

[johnme, 2016-04-05 19:15:06]

(See also discarded previous patches https://codereview.chromium.org/1736433002
and https://codereview.chromium.org/1731913002)

[johnme, 2016-04-05 19:15:15]

[email protected] changed reviewers:
+ [email protected]

[jianli, 2016-04-08 00:20:43]

lgtm

https://codereview.chromium.org/1854093002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/instance_id/instance_id_apitest.cc (right):

https://codereview.chromium.org/1854093002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/instance_id/instance_id_apitest.cc:7: #include
"base/base_switches.h"
nit: remove this

[johnme, 2016-04-08 13:19:43]

[email protected] changed reviewers:
+ [email protected]

[johnme, 2016-04-08 13:19:43]

asvitkine: please review testing/variations/ - thanks!

https://codereview.chromium.org/1854093002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/instance_id/instance_id_apitest.cc (right):

https://codereview.chromium.org/1854093002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/instance_id/instance_id_apitest.cc:7: #include
"base/base_switches.h"
On 2016/04/08 00:20:43, jianli wrote:
> nit: remove this

Done.

[Alexei Svitkine (slow), 2016-04-08 15:11:03]

https://codereview.chromium.org/1854093002/diff/40001/components/gcm_driver/i...
File components/gcm_driver/instance_id/instance_id_driver.cc (right):

https://codereview.chromium.org/1854093002/diff/40001/components/gcm_driver/i...
components/gcm_driver/instance_id/instance_id_driver.cc:23: return group_name !=
kInstanceIDFieldTrialDisabledGroupName;
Our best practices recommend using StartsWith() for group checks. This way, you
can have differently named groups with the same behavior - which is useful for
example when tweaking percentages to prevent biases from the old population.

https://codereview.chromium.org/1854093002/diff/40001/testing/variations/fiel...
File testing/variations/fieldtrial_testing_config_linux.json (left):

https://codereview.chromium.org/1854093002/diff/40001/testing/variations/fiel...
testing/variations/fieldtrial_testing_config_linux.json:69: "InstanceID": [
This is still worth having while you have a field-trial control, since our
server-side analysis tools expect this to exist.

[johnme, 2016-04-08 15:28:10]

Addressed asvitkine's review comments - thanks!

https://codereview.chromium.org/1854093002/diff/40001/components/gcm_driver/i...
File components/gcm_driver/instance_id/instance_id_driver.cc (right):

https://codereview.chromium.org/1854093002/diff/40001/components/gcm_driver/i...
components/gcm_driver/instance_id/instance_id_driver.cc:23: return group_name !=
kInstanceIDFieldTrialDisabledGroupName;
On 2016/04/08 15:11:03, Alexei Svitkine wrote:
> Our best practices recommend using StartsWith() for group checks. This way,
you
> can have differently named groups with the same behavior - which is useful for
> example when tweaking percentages to prevent biases from the old population.

Done (I used case-insensitive StartsWith, since it seems that'd reduce the
danger of typos).

https://codereview.chromium.org/1854093002/diff/40001/testing/variations/fiel...
File testing/variations/fieldtrial_testing_config_linux.json (left):

https://codereview.chromium.org/1854093002/diff/40001/testing/variations/fiel...
testing/variations/fieldtrial_testing_config_linux.json:69: "InstanceID": [
On 2016/04/08 15:11:03, Alexei Svitkine wrote:
> This is still worth having while you have a field-trial control, since our
> server-side analysis tools expect this to exist.

Done (good to know - thanks!).

[Peter Beverloo, 2016-04-11 14:19:17]

[email protected] changed reviewers:
+ [email protected]

[Peter Beverloo, 2016-04-11 14:19:17]

lgtm

[Alexei Svitkine (slow), 2016-04-11 14:53:07]

lgtm

[johnme, 2016-04-18 14:23:32]

Description was changed from

==========
Enable InstanceID field trial by default

This makes it easier to write tests, since each test doesn't have to
enable the field trial (which is especially hard from Java).

Part of a series of patches:
1. https://codereview.chromium.org/1832833002 adds InstanceIDWithSubtype
2. https://codereview.chromium.org/1830983002 adds JNI bindings
3. https://codereview.chromium.org/1829023002 adds fake and test
4. this patch
5. https://codereview.chromium.org/1851423003 switches Push to InstanceIDs

BUG=589461, 477084
==========

to

==========
Enable InstanceID field trial by default

This makes it easier to write tests, since each test doesn't have to
enable the field trial (which is especially hard from Java).

Part of a series of patches:
1. https://codereview.chromium.org/1832833002 adds InstanceIDWithSubtype
2. https://codereview.chromium.org/1830983002 adds JNI bindings
3. https://codereview.chromium.org/1829023002 adds fake and test
4. https://codereview.chromium.org/1899753002 fixes strict mode violations
5. this patch
6. https://codereview.chromium.org/1851423003 switches Push to InstanceIDs

BUG=589461, 477084
==========

[johnme, 2016-04-27 18:00:24]

Description was changed from

==========
Enable InstanceID field trial by default

This makes it easier to write tests, since each test doesn't have to
enable the field trial (which is especially hard from Java).

Part of a series of patches:
1. https://codereview.chromium.org/1832833002 adds InstanceIDWithSubtype
2. https://codereview.chromium.org/1830983002 adds JNI bindings
3. https://codereview.chromium.org/1829023002 adds fake and test
4. https://codereview.chromium.org/1899753002 fixes strict mode violations
5. this patch
6. https://codereview.chromium.org/1851423003 switches Push to InstanceIDs

BUG=589461, 477084
==========

to

==========
Enable InstanceID field trial by default

This makes it easier to write tests, since each test doesn't have to
enable the field trial (which is especially hard from Java).

Part of a series of patches:
1. https://codereview.chromium.org/1832833002 adds InstanceIDWithSubtype
2. https://codereview.chromium.org/1830983002 adds JNI bindings
3. https://codereview.chromium.org/1829023002 adds fake and test
4. https://codereview.chromium.org/1899753002 fixes strict mode violations
5. this patch
6. https://codereview.chromium.org/1923953002 adds crypto integration
7. https://codereview.chromium.org/1851423003 switches Push to InstanceIDs

BUG=589461, 477084
==========

[johnme, 2016-04-28 09:49:30]

The CQ bit was checked by [email protected]

[johnme, 2016-04-28 09:49:31]

The patchset sent to the CQ was uploaded after l-g-t-m from [email protected],
[email protected], [email protected]
Link to the patchset: https://codereview.chromium.org/1854093002/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2016-04-28 09:49:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854093002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854093002/100001

[commit-bot: I haz the power, 2016-04-28 10:32:20]

Description was changed from

==========
Enable InstanceID field trial by default

This makes it easier to write tests, since each test doesn't have to
enable the field trial (which is especially hard from Java).

Part of a series of patches:
1. https://codereview.chromium.org/1832833002 adds InstanceIDWithSubtype
2. https://codereview.chromium.org/1830983002 adds JNI bindings
3. https://codereview.chromium.org/1829023002 adds fake and test
4. https://codereview.chromium.org/1899753002 fixes strict mode violations
5. this patch
6. https://codereview.chromium.org/1923953002 adds crypto integration
7. https://codereview.chromium.org/1851423003 switches Push to InstanceIDs

BUG=589461, 477084
==========

to

==========
Enable InstanceID field trial by default

This makes it easier to write tests, since each test doesn't have to
enable the field trial (which is especially hard from Java).

Part of a series of patches:
1. https://codereview.chromium.org/1832833002 adds InstanceIDWithSubtype
2. https://codereview.chromium.org/1830983002 adds JNI bindings
3. https://codereview.chromium.org/1829023002 adds fake and test
4. https://codereview.chromium.org/1899753002 fixes strict mode violations
5. this patch
6. https://codereview.chromium.org/1923953002 adds crypto integration
7. https://codereview.chromium.org/1851423003 switches Push to InstanceIDs

BUG=589461, 477084
==========

[commit-bot: I haz the power, 2016-04-28 10:32:22]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-04-30 17:17:18]

Patchset 6 (id:??) landed as
https://crrev.com/384d15da99c3e9460ee87016aeb6f3387f20dc98
Cr-Commit-Position: refs/heads/master@{#390339}

[commit-bot: I haz the power, 2016-04-30 17:55:01]

Description was changed from

==========
Enable InstanceID field trial by default

This makes it easier to write tests, since each test doesn't have to
enable the field trial (which is especially hard from Java).

Part of a series of patches:
1. https://codereview.chromium.org/1832833002 adds InstanceIDWithSubtype
2. https://codereview.chromium.org/1830983002 adds JNI bindings
3. https://codereview.chromium.org/1829023002 adds fake and test
4. https://codereview.chromium.org/1899753002 fixes strict mode violations
5. this patch
6. https://codereview.chromium.org/1923953002 adds crypto integration
7. https://codereview.chromium.org/1851423003 switches Push to InstanceIDs

BUG=589461, 477084
==========

to

==========
Enable InstanceID field trial by default

This makes it easier to write tests, since each test doesn't have to
enable the field trial (which is especially hard from Java).

Part of a series of patches:
1. https://codereview.chromium.org/1832833002 adds InstanceIDWithSubtype
2. https://codereview.chromium.org/1830983002 adds JNI bindings
3. https://codereview.chromium.org/1829023002 adds fake and test
4. https://codereview.chromium.org/1899753002 fixes strict mode violations
5. this patch
6. https://codereview.chromium.org/1923953002 adds crypto integration
7. https://codereview.chromium.org/1851423003 switches Push to InstanceIDs

BUG=589461, 477084

Committed: https://crrev.com/384d15da99c3e9460ee87016aeb6f3387f20dc98
Cr-Commit-Position: refs/heads/master@{#390339}
==========