Rate limit programmatic update checks for extensions (reland)

Rate limit programmatic update checks for extensions (reland)

Previously extensions could call the runtime.requestUpdateCheck method
as often as every 5 seconds. This CL introduces a more restrictive
policy of around one extra check per autoupdate period, and changes the
implementation location of the rate limiting from within the
ExtensionUpdater code itself to the ChromeRuntimeAPIDelegate, and makes
it more flexible by using net::BackoffEntry.

This is a reland of https://codereview.chromium.org/1887253002, with
the removal of a static initializer.

BUG=599310
Committed: https://crrev.com/d50b18c369e5caf46c15c579ccbb28d7dcf84c2c
Cr-Commit-Position: refs/heads/master@{#388654}

[asargent_no_longer_on_chrome, 2016-04-20 21:18:03]

[email protected] changed reviewers:
+ [email protected]

[asargent_no_longer_on_chrome, 2016-04-20 21:18:04]

Devlin, can you take a look at this fix to my previous CL? It had to be reverted
because it generated a static initializer.

I was confused how this could happen because there are lots of other static
instances of net::BackoffEntry::Policy that don't generate static initializers -
it turned out to be an issue with my CL because I reference the
extensions::kDefaultUpdateFrequencySeconds value for one of the struct's values,
which happens to be defined in another library, so I guess the compiler had to
generate a static initializer to be able to resolve its value.

I've changed to using a LazyInstance - you can diff patch sets 1 and 2 of this
CL to see just that change.

[Devlin, 2016-04-20 22:09:31]

lgtm

https://codereview.chromium.org/1897293005/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc
(right):

https://codereview.chromium.org/1897293005/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc:75: const
net::BackoffEntry::Policy* policy() { return &policy_; }
nit: maybe just have Get() return this?

static net::BackoffEntry::Policy* Get() {
  return &g_backoff_policy.Pointer()->policy_;
}

[asargent_no_longer_on_chrome, 2016-04-20 22:44:59]

https://codereview.chromium.org/1897293005/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc
(right):

https://codereview.chromium.org/1897293005/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc:75: const
net::BackoffEntry::Policy* policy() { return &policy_; }
On 2016/04/20 22:09:31, Devlin wrote:
> nit: maybe just have Get() return this?
> 
> static net::BackoffEntry::Policy* Get() {
>   return &g_backoff_policy.Pointer()->policy_;
> }

Good idea, done.

[asargent_no_longer_on_chrome, 2016-04-20 22:45:05]

The CQ bit was checked by [email protected]

[asargent_no_longer_on_chrome, 2016-04-20 22:45:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
[email protected]
Link to the patchset: https://codereview.chromium.org/1897293005/#ps40001
(title: "have Get() just return the net::BackoffEntry::Policy directly")

[commit-bot: I haz the power, 2016-04-20 22:45:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1897293005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1897293005/40001

[commit-bot: I haz the power, 2016-04-20 23:50:38]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-04-20 23:50:38]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[asargent_no_longer_on_chrome, 2016-04-21 00:04:52]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2016-04-21 00:05:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1897293005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1897293005/40001

[commit-bot: I haz the power, 2016-04-21 01:17:26]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-22 19:29:59]

Description was changed from

==========
Rate limit programmatic update checks for extensions (reland)

Previously extensions could call the runtime.requestUpdateCheck method
as often as every 5 seconds. This CL introduces a more restrictive
policy of around one extra check per autoupdate period, and changes the
implementation location of the rate limiting from within the
ExtensionUpdater code itself to the ChromeRuntimeAPIDelegate, and makes
it more flexible by using net::BackoffEntry.

This is a reland of https://codereview.chromium.org/1887253002, with
the removal of a static initializer.

BUG=599310
==========

to

==========
Rate limit programmatic update checks for extensions (reland)

Previously extensions could call the runtime.requestUpdateCheck method
as often as every 5 seconds. This CL introduces a more restrictive
policy of around one extra check per autoupdate period, and changes the
implementation location of the rate limiting from within the
ExtensionUpdater code itself to the ChromeRuntimeAPIDelegate, and makes
it more flexible by using net::BackoffEntry.

This is a reland of https://codereview.chromium.org/1887253002, with
the removal of a static initializer.

BUG=599310

Committed: https://crrev.com/d50b18c369e5caf46c15c579ccbb28d7dcf84c2c
Cr-Commit-Position: refs/heads/master@{#388654}
==========

[commit-bot: I haz the power, 2016-04-22 19:30:00]

Patchset 3 (id:??) landed as
https://crrev.com/d50b18c369e5caf46c15c579ccbb28d7dcf84c2c
Cr-Commit-Position: refs/heads/master@{#388654}