Move Cast certificate verification code from extensions to components.

Move Cast certificate verification code from extensions to components.

The Cast certificate verification code was previously only used by the
Cast extension. Cast platform would also like to use this code. It did
not make sense to leave this code in extensions as extensions is disabled
on platforms like Android while Cast supports Android TVs.

This CL moves //extensions/common/cast to //components/cast_certificate.
The associated unittests are now included in the components unittests.
Test data for these unittests relocated from //extensions/test/data to
//components/test/data.

BUG=607373
Committed: https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589
Cr-Commit-Position: refs/heads/master@{#391834}

[ryanchung, 2016-04-28 16:32:52]

Description was changed from

==========
Move Cast certificate verification code from extensions to components.

The Cast certificate verification code was previously only used by the
Cast extension. Cast platform would also like to use this code. It did
not make sense to leave this code in extensions as extensions is disabled
on platforms like Android while Cast supports Android TVs.

This CL moves //extensions/common/cast to //components/cast_certificate.
The associated unittests are now included in the components unittests.
Test data for these unittests relocated from //extensions/test/data to
//components/test/data.

BUG=607373
==========

to

==========
Move Cast certificate verification code from extensions to components.

The Cast certificate verification code was previously only used by the
Cast extension. Cast platform would also like to use this code. It did
not make sense to leave this code in extensions as extensions is disabled
on platforms like Android while Cast supports Android TVs.

This CL moves //extensions/common/cast to //components/cast_certificate.
The associated unittests are now included in the components unittests.
Test data for these unittests relocated from //extensions/test/data to
//components/test/data.

BUG=607373
==========

[ryanchung, 2016-04-28 16:32:53]

[email protected] changed reviewers:
+ [email protected], [email protected]

[eroman, 2016-04-28 19:50:21]

lgtm

https://codereview.chromium.org/1924323002/diff/1/chrome/common/extensions/ap...
File
chrome/common/extensions/api/networking_private/networking_private_crypto_unittest.cc
(right):

https://codereview.chromium.org/1924323002/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/networking_private/networking_private_crypto_unittest.cc:40:
// TODO(eroman): Avoid duplicating the data.
Side-note: this should be easy to solve now, since we can depend on your newly
added //components/cast_certificate:test_support and re-use the certificate data
and file readers.

https://codereview.chromium.org/1924323002/diff/1/components/cast_certificate...
File components/cast_certificate/OWNERS (right):

https://codereview.chromium.org/1924323002/diff/1/components/cast_certificate...
components/cast_certificate/OWNERS:1: [email protected]
should Andrei and Vadim be in here too?

https://codereview.chromium.org/1924323002/diff/1/components/cast_certificate...
File components/cast_certificate/cast_cert_validator.h (right):

https://codereview.chromium.org/1924323002/diff/1/components/cast_certificate...
components/cast_certificate/cast_cert_validator.h:5: #ifndef
EXTENSIONS_COMMON_CAST_CAST_CERT_VALIDATOR_H_
Update this.

https://codereview.chromium.org/1924323002/diff/1/components/cast_certificate...
File components/cast_certificate/cast_cert_validator_test_helpers.h (right):

https://codereview.chromium.org/1924323002/diff/1/components/cast_certificate...
components/cast_certificate/cast_cert_validator_test_helpers.h:5: #ifndef
EXTENSIONS_COMMON_CAST_CAST_CERT_VALIDATOR_TEST_HELPERS_H_
Update this.

https://codereview.chromium.org/1924323002/diff/1/components/cast_certificate...
components/cast_certificate/cast_cert_validator_test_helpers.h:13: namespace
cast_test_helpers {
This should probably be inside the cast_certificate namespace since it is a
component now.

Perhaps:

cast_certificate::testing ?

https://codereview.chromium.org/1924323002/diff/1/components/test/data/cast_c...
File components/test/data/cast_certificate/signeddata/2ZZBG9_FA8FCA3EF91A.pem
(right):

https://codereview.chromium.org/1924323002/diff/1/components/test/data/cast_c...
components/test/data/cast_certificate/signeddata/2ZZBG9_FA8FCA3EF91A.pem:5:
../cast_certificates/chromecast_gen1.pem
Update this comment as the path has chagned:

../certificates/chromecast_gen1.pem

(this comment applies to all the signeddata files too).

[ryanchung, 2016-04-28 20:30:56]

Thanks!

https://codereview.chromium.org/1924323002/diff/1/components/cast_certificate...
File components/cast_certificate/OWNERS (right):

https://codereview.chromium.org/1924323002/diff/1/components/cast_certificate...
components/cast_certificate/OWNERS:1: [email protected]
On 2016/04/28 19:50:20, eroman wrote:
> should Andrei and Vadim be in here too?

Done.

https://codereview.chromium.org/1924323002/diff/1/components/cast_certificate...
File components/cast_certificate/cast_cert_validator.h (right):

https://codereview.chromium.org/1924323002/diff/1/components/cast_certificate...
components/cast_certificate/cast_cert_validator.h:5: #ifndef
EXTENSIONS_COMMON_CAST_CAST_CERT_VALIDATOR_H_
On 2016/04/28 19:50:20, eroman wrote:
> Update this.

Done.

https://codereview.chromium.org/1924323002/diff/1/components/cast_certificate...
File components/cast_certificate/cast_cert_validator_test_helpers.h (right):

https://codereview.chromium.org/1924323002/diff/1/components/cast_certificate...
components/cast_certificate/cast_cert_validator_test_helpers.h:5: #ifndef
EXTENSIONS_COMMON_CAST_CAST_CERT_VALIDATOR_TEST_HELPERS_H_
On 2016/04/28 19:50:21, eroman wrote:
> Update this.

Done.

https://codereview.chromium.org/1924323002/diff/1/components/cast_certificate...
components/cast_certificate/cast_cert_validator_test_helpers.h:13: namespace
cast_test_helpers {
On 2016/04/28 19:50:20, eroman wrote:
> This should probably be inside the cast_certificate namespace since it is a
> component now.
> 
> Perhaps:
> 
> cast_certificate::testing ?

Done.

https://codereview.chromium.org/1924323002/diff/1/components/test/data/cast_c...
File components/test/data/cast_certificate/signeddata/2ZZBG9_FA8FCA3EF91A.pem
(right):

https://codereview.chromium.org/1924323002/diff/1/components/test/data/cast_c...
components/test/data/cast_certificate/signeddata/2ZZBG9_FA8FCA3EF91A.pem:5:
../cast_certificates/chromecast_gen1.pem
On 2016/04/28 19:50:21, eroman wrote:
> Update this comment as the path has chagned:
> 
> ../certificates/chromecast_gen1.pem
> 
> (this comment applies to all the signeddata files too).

Done.

[sheretov, 2016-04-29 15:19:21]

LGTM

Would it make sense to replicate components/cast_certificate/OWNERS in
components/test/data/cast_certificate/OWNERS?

[ryanchung, 2016-04-29 15:43:54]

On 2016/04/29 15:19:21, sheretov wrote:
> Would it make sense to replicate components/cast_certificate/OWNERS in
> components/test/data/cast_certificate/OWNERS?

Done. I think that makes sense.

[ryanchung, 2016-04-29 15:56:25]

[email protected] changed reviewers:
+ [email protected], [email protected], [email protected]

[ryanchung, 2016-04-29 15:56:26]

+jochen
Please review //chrome and //components

+asargent
Please review //extensions
and chrome/common/extensions/api/networking_private

+kmarshall
Please review //extensions/browser/api/cast_channel

Thanks!

[eroman, 2016-04-29 16:47:57]

https://codereview.chromium.org/1924323002/diff/100001/components/cast_certif...
File components/cast_certificate/OWNERS (right):

https://codereview.chromium.org/1924323002/diff/100001/components/cast_certif...
components/cast_certificate/OWNERS:1: [email protected]
Rather than duplicating the owners from chromecast/OWNERS, can this be written
as:

file://chromecast/OWNERS
[email protected]
[email protected]

?

https://codereview.chromium.org/1924323002/diff/100001/components/test/data/c...
File components/test/data/cast_certificate/OWNERS (right):

https://codereview.chromium.org/1924323002/diff/100001/components/test/data/c...
components/test/data/cast_certificate/OWNERS:1: [email protected]
Rather than duplicating, can this OWNERS link to the other one?

file://components/cast_certificate/OWNERS

[ryanchung, 2016-04-29 17:14:44]

https://codereview.chromium.org/1924323002/diff/100001/components/cast_certif...
File components/cast_certificate/OWNERS (right):

https://codereview.chromium.org/1924323002/diff/100001/components/cast_certif...
components/cast_certificate/OWNERS:1: [email protected]
On 2016/04/29 16:47:57, eroman wrote:
> Rather than duplicating the owners from chromecast/OWNERS, can this be written
> as:
> 
> file://chromecast/OWNERS
> mailto:[email protected]
> mailto:[email protected]
> 
> ?

Done. Good idea. Thanks.

https://codereview.chromium.org/1924323002/diff/100001/components/test/data/c...
File components/test/data/cast_certificate/OWNERS (right):

https://codereview.chromium.org/1924323002/diff/100001/components/test/data/c...
components/test/data/cast_certificate/OWNERS:1: [email protected]
On 2016/04/29 16:47:57, eroman wrote:
> Rather than duplicating, can this OWNERS link to the other one?
> 
> file://components/cast_certificate/OWNERS

Done.

[asargent_no_longer_on_chrome, 2016-04-29 17:35:58]

extensions parts lgtm

[jochen (gone - plz use gerrit), 2016-05-02 17:02:59]

lgtm

[Kevin M, 2016-05-02 21:53:17]

[email protected] changed reviewers:
+ [email protected]

[Kevin M, 2016-05-02 21:53:18]

-me (not working on Cast anymore)
+vadimgo

[vadimgo, 2016-05-05 17:13:09]

lgtm

[ryanchung, 2016-05-05 17:16:48]

The CQ bit was checked by [email protected]

[ryanchung, 2016-05-05 17:16:49]

The patchset sent to the CQ was uploaded after l-g-t-m from [email protected],
[email protected]
Link to the patchset: https://codereview.chromium.org/1924323002/#ps120001
(title: "Simplified OWNERS files")

[commit-bot: I haz the power, 2016-05-05 17:17:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1924323002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1924323002/120001

[commit-bot: I haz the power, 2016-05-05 17:22:26]

Description was changed from

==========
Move Cast certificate verification code from extensions to components.

The Cast certificate verification code was previously only used by the
Cast extension. Cast platform would also like to use this code. It did
not make sense to leave this code in extensions as extensions is disabled
on platforms like Android while Cast supports Android TVs.

This CL moves //extensions/common/cast to //components/cast_certificate.
The associated unittests are now included in the components unittests.
Test data for these unittests relocated from //extensions/test/data to
//components/test/data.

BUG=607373
==========

to

==========
Move Cast certificate verification code from extensions to components.

The Cast certificate verification code was previously only used by the
Cast extension. Cast platform would also like to use this code. It did
not make sense to leave this code in extensions as extensions is disabled
on platforms like Android while Cast supports Android TVs.

This CL moves //extensions/common/cast to //components/cast_certificate.
The associated unittests are now included in the components unittests.
Test data for these unittests relocated from //extensions/test/data to
//components/test/data.

BUG=607373
==========

[commit-bot: I haz the power, 2016-05-05 17:22:27]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-05-05 17:24:05]

Description was changed from

==========
Move Cast certificate verification code from extensions to components.

The Cast certificate verification code was previously only used by the
Cast extension. Cast platform would also like to use this code. It did
not make sense to leave this code in extensions as extensions is disabled
on platforms like Android while Cast supports Android TVs.

This CL moves //extensions/common/cast to //components/cast_certificate.
The associated unittests are now included in the components unittests.
Test data for these unittests relocated from //extensions/test/data to
//components/test/data.

BUG=607373
==========

to

==========
Move Cast certificate verification code from extensions to components.

The Cast certificate verification code was previously only used by the
Cast extension. Cast platform would also like to use this code. It did
not make sense to leave this code in extensions as extensions is disabled
on platforms like Android while Cast supports Android TVs.

This CL moves //extensions/common/cast to //components/cast_certificate.
The associated unittests are now included in the components unittests.
Test data for these unittests relocated from //extensions/test/data to
//components/test/data.

BUG=607373

Committed: https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589
Cr-Commit-Position: refs/heads/master@{#391834}
==========

[commit-bot: I haz the power, 2016-05-05 17:24:06]

Patchset 7 (id:??) landed as
https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589
Cr-Commit-Position: refs/heads/master@{#391834}