Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2002083002: Add QuicSentPacketManagerInterface, and QuicSentPacketManager implements it. No functional change e… (Closed)

Created:
4 years, 7 months ago by Fan Yang
Modified:
4 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add QuicSentPacketManagerInterface, and QuicSentPacketManager implements it. No functional change expected. Merge internal change: 122420070 [email protected] BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+583 lines, -317 lines) Patch
M net/net.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_chromium_client_session.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_connection.h View 8 chunks +17 lines, -14 lines 0 comments Download
M net/quic/quic_connection.cc View 36 chunks +95 lines, -61 lines 0 comments Download
M net/quic/quic_connection_test.cc View 6 chunks +18 lines, -8 lines 0 comments Download
M net/quic/quic_flow_controller_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/quic_sent_packet_manager.h View 6 chunks +55 lines, -108 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 11 chunks +60 lines, -34 lines 0 comments Download
A net/quic/quic_sent_packet_manager_interface.h View 1 chunk +193 lines, -0 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 28 chunks +83 lines, -61 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_sent_packet_manager_peer.h View 3 chunks +8 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_sent_packet_manager_peer.cc View 4 chunks +11 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 6 chunks +14 lines, -10 lines 0 comments Download
M net/tools/quic/quic_server_session_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_server_session_base_test.cc View 2 chunks +5 lines, -1 line 0 comments Download

Dependent Patchsets:

Issue 2005853002 Patch 20001

Messages

Total messages: 7 (3 generated)
Fan Yang
4 years, 7 months ago (2016-05-23 13:46:27 UTC) #2
Ryan Hamilton
lgtm
4 years, 7 months ago (2016-05-23 15:50:12 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002083002/20001
4 years, 7 months ago (2016-05-26 01:05:41 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 01:20:35 UTC) #7 
Dry run: Try jobs failed on following builders:
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)

Powered by Google App Engine
This is Rietveld 408576698