Change a number of SPDY unittests from http to https.

Change a number of SPDY unittests from http to https.

* Remove enable_alternative_service_for_insecure_origins;
* change alternative service unittests from http to https;
* change kDefaultUrl from http to https;
* s/kDefaultURL/kDefaultUrl/ (to match the one in QuicStreamFactoryTest);
* adapt a number of tests, explicitly use old URL in others;
* remove SpdyTestUtil::default_url();
* remove moot SpdyAlternativeServiceThroughProxy;
* remove SpdyNetworkTransactionTest::GetDefaultUrl() and port_;
* add SpdyNetworkTransactionTest members to make tests more concise.

Besides an improvement in code health, this CL will make it easier to write
unittests for https://crbug.com/615413.

BUG=621621, 624073
Committed: https://crrev.com/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f
Cr-Commit-Position: refs/heads/master@{#402686}

[Bence, 2016-06-28 20:09:20]

[email protected] changed reviewers:
+ [email protected]

[Bence, 2016-06-28 20:09:21]

Ryan: PTAL.  Thank you.

https://codereview.chromium.org/2109803002/diff/1/net/http/http_network_trans...
File net/http/http_network_transaction_unittest.cc (left):

https://codereview.chromium.org/2109803002/diff/1/net/http/http_network_trans...
net/http/http_network_transaction_unittest.cc:10263:
TEST_P(HttpNetworkTransactionTest, DisableAlternativeServiceToDifferentHost) {
After changing to https, this is totally redundant with
DisableHTTP2AlternativeServicesWithDifferentHost.

https://codereview.chromium.org/2109803002/diff/1/net/http/http_network_trans...
net/http/http_network_transaction_unittest.cc:12073:
TEST_P(HttpNetworkTransactionTest, SpdyAlternativeServiceThroughProxy) {
Alternative Service is not allowed for http scheme any more.

[Ryan Hamilton, 2016-06-28 22:57:35]

lgtm

https://codereview.chromium.org/2109803002/diff/1/net/spdy/spdy_network_trans...
File net/spdy/spdy_network_transaction_unittest.cc (right):

https://codereview.chromium.org/2109803002/diff/1/net/spdy/spdy_network_trans...
net/spdy/spdy_network_transaction_unittest.cc:64: enum
SpdyNetworkTransactionTestSSLType {
Is this really "SSL type" any more? Fix in a followup?

[Bence, 2016-06-29 00:39:15]

The CQ bit was checked by [email protected]

[Bence, 2016-06-29 00:39:15]

The patchset sent to the CQ was uploaded after l-g-t-m from [email protected]
Link to the patchset: https://codereview.chromium.org/2109803002/#ps20001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-06-29 00:41:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 02:39:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-29 02:43:18]

Description was changed from

==========
Change a number of SPDY unittests from http to https.

* Remove enable_alternative_service_for_insecure_origins;
* change alternative service unittests from http to https;
* change kDefaultUrl from http to https;
* s/kDefaultURL/kDefaultUrl/ (to match the one in QuicStreamFactoryTest);
* adapt a number of tests, explicitly use old URL in others;
* remove SpdyTestUtil::default_url();
* remove moot SpdyAlternativeServiceThroughProxy;
* remove SpdyNetworkTransactionTest::GetDefaultUrl() and port_;
* add SpdyNetworkTransactionTest members to make tests more concise.

Besides an improvement in code health, this CL will make it easier to write
unittests for https://crbug.com/615413.

BUG=621621, 624073
==========

to

==========
Change a number of SPDY unittests from http to https.

* Remove enable_alternative_service_for_insecure_origins;
* change alternative service unittests from http to https;
* change kDefaultUrl from http to https;
* s/kDefaultURL/kDefaultUrl/ (to match the one in QuicStreamFactoryTest);
* adapt a number of tests, explicitly use old URL in others;
* remove SpdyTestUtil::default_url();
* remove moot SpdyAlternativeServiceThroughProxy;
* remove SpdyNetworkTransactionTest::GetDefaultUrl() and port_;
* add SpdyNetworkTransactionTest members to make tests more concise.

Besides an improvement in code health, this CL will make it easier to write
unittests for https://crbug.com/615413.

BUG=621621, 624073

Committed: https://crrev.com/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f
Cr-Commit-Position: refs/heads/master@{#402686}
==========

[commit-bot: I haz the power, 2016-06-29 02:43:19]

Patchset 2 (id:??) landed as
https://crrev.com/b2602438cbcdd99e6eb34d8be9c54d65e8bf087f
Cr-Commit-Position: refs/heads/master@{#402686}

[Bence, 2016-06-30 18:19:53]

Thank you.

https://codereview.chromium.org/2109803002/diff/1/net/spdy/spdy_network_trans...
File net/spdy/spdy_network_transaction_unittest.cc (right):

https://codereview.chromium.org/2109803002/diff/1/net/spdy/spdy_network_trans...
net/spdy/spdy_network_transaction_unittest.cc:64: enum
SpdyNetworkTransactionTestSSLType {
On 2016/06/28 22:57:35, Ryan Hamilton wrote:
> Is this really "SSL type" any more? Fix in a followup?

Aaaand https://crrev.com/2109593007 fixes it for good.