Issue 2121383004: Add a bool demand_x509_proof argument to QuicCryptoClientConfig::FillInchoateClientHello to conditi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2121383004: Add a bool demand_x509_proof argument to QuicCryptoClientConfig::FillInchoateClientHello to conditi… (Closed)

Created:
4 years, 5 months ago by rjshade

Modified:
4 years, 5 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@126002268

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add a bool demand_x509_proof argument to QuicCryptoClientConfig::FillInchoateClientHello to conditionally add x509 related fields to QUIC CHLOs. Merge internal change: 126089643 [email protected] BUG=

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -11 lines)			Patch
M	net/quic/crypto/quic_crypto_client_config.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	net/quic/crypto/quic_crypto_client_config.cc	View	4 chunks	+10 lines, -5 lines	0 comments	Download
M	net/quic/crypto/quic_crypto_client_config_test.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	net/quic/quic_crypto_client_stream.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Depends on Patchset:

Issue 2128623002 Patch 1

Dependent Patchsets:

Issue 2121293003 Patch 1

Issue 2121293003 Patch 20001

Issue 2121293003 Patch 40001

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages