[Extensions] Move Feature channel code into //extensions

[Extensions] Move Feature channel code into //extensions

Channel code used to be in //chrome, so it couldn't be used in
//extensions.  Now that it's moved to components/, we can safely
include it and can simplify Features code significantly.

BUG=626774
Committed: https://crrev.com/4122753620f4aa139b0606912a00491733a59b65
Cr-Commit-Position: refs/heads/master@{#405285}

[Devlin, 2016-07-08 21:20:20]

[email protected] changed reviewers:
+ [email protected]

[Devlin, 2016-07-08 21:20:21]

Slightly larger one, sorry.  Mostly straightforward, though!

https://codereview.chromium.org/2137463003/diff/1/chrome/common/extensions/fe...
File chrome/common/extensions/features/chrome_channel_feature_filter.cc (left):

https://codereview.chromium.org/2137463003/diff/1/chrome/common/extensions/fe...
chrome/common/extensions/features/chrome_channel_feature_filter.cc:1: //
Copyright 2014 The Chromium Authors. All rights reserved.
This file's functionality is now in simple_feature.cc

https://codereview.chromium.org/2137463003/diff/1/chrome/common/extensions/fe...
File chrome/common/extensions/features/chrome_channel_feature_filter_unittest.cc
(left):

https://codereview.chromium.org/2137463003/diff/1/chrome/common/extensions/fe...
chrome/common/extensions/features/chrome_channel_feature_filter_unittest.cc:1:
// Copyright 2014 The Chromium Authors. All rights reserved.
This file basically just got moved to simple_feature_unittest.cc

https://codereview.chromium.org/2137463003/diff/1/extensions/common/features/...
File extensions/common/features/complex_feature.cc (left):

https://codereview.chromium.org/2137463003/diff/1/extensions/common/features/...
extensions/common/features/complex_feature.cc:105: std::string
ComplexFeature::GetAvailabilityMessage(AvailabilityResult result,
Strangely, the only time this is actually called is by line 114 (in this
method), so I believe this was unused.

[lazyboy, 2016-07-12 00:35:13]

lgtm with nits/suggestions.

https://codereview.chromium.org/2137463003/diff/1/chrome/common/extensions/fe...
File chrome/common/extensions/features/chrome_channel_feature_filter.cc (left):

https://codereview.chromium.org/2137463003/diff/1/chrome/common/extensions/fe...
chrome/common/extensions/features/chrome_channel_feature_filter.cc:1: //
Copyright 2014 The Chromium Authors. All rights reserved.
On 2016/07/08 21:20:21, Devlin wrote:
> This file's functionality is now in simple_feature.cc

Acknowledged.

https://codereview.chromium.org/2137463003/diff/1/chrome/common/extensions/fe...
File chrome/common/extensions/features/chrome_channel_feature_filter_unittest.cc
(left):

https://codereview.chromium.org/2137463003/diff/1/chrome/common/extensions/fe...
chrome/common/extensions/features/chrome_channel_feature_filter_unittest.cc:1:
// Copyright 2014 The Chromium Authors. All rights reserved.
On 2016/07/08 21:20:21, Devlin wrote:
> This file basically just got moved to simple_feature_unittest.cc

Acknowledged.

https://codereview.chromium.org/2137463003/diff/1/extensions/common/features/...
File extensions/common/features/complex_feature.cc (left):

https://codereview.chromium.org/2137463003/diff/1/extensions/common/features/...
extensions/common/features/complex_feature.cc:105: std::string
ComplexFeature::GetAvailabilityMessage(AvailabilityResult result,
On 2016/07/08 21:20:21, Devlin wrote:
> Strangely, the only time this is actually called is by line 114 (in this
> method), so I believe this was unused.

Acknowledged.

https://codereview.chromium.org/2137463003/diff/1/extensions/common/features/...
File extensions/common/features/simple_feature.cc (left):

https://codereview.chromium.org/2137463003/diff/1/extensions/common/features/...
extensions/common/features/simple_feature.cc:297: void
SimpleFeature::AddFilter(std::unique_ptr<SimpleFeatureFilter> filter) {
As we're not using SimpleFeatureFilter anymore, we should delete the class/file
(I can't see that in this CL).

https://codereview.chromium.org/2137463003/diff/1/extensions/common/features/...
File extensions/common/features/simple_feature.cc (right):

https://codereview.chromium.org/2137463003/diff/1/extensions/common/features/...
extensions/common/features/simple_feature.cc:303: std::map<std::string,
version_info::Channel> channels;
nit: any reason this is here and not after |platforms|? (same order we
initialize this in the ctor).

https://codereview.chromium.org/2137463003/diff/1/extensions/common/features/...
extensions/common/features/simple_feature.cc:430: if (channel_ && *channel_ <
GetCurrentChannel()) {
nit: drop {}

[Devlin, 2016-07-12 19:10:00]

https://codereview.chromium.org/2137463003/diff/1/extensions/common/features/...
File extensions/common/features/simple_feature.cc (left):

https://codereview.chromium.org/2137463003/diff/1/extensions/common/features/...
extensions/common/features/simple_feature.cc:297: void
SimpleFeature::AddFilter(std::unique_ptr<SimpleFeatureFilter> filter) {
On 2016/07/12 00:35:12, lazyboy wrote:
> As we're not using SimpleFeatureFilter anymore, we should delete the
class/file
> (I can't see that in this CL).

Whoops!  Meant to do that, but looks like I only grabbed
ChromeChannelFeatureFilter.  Thanks for catching it.  Done.

https://codereview.chromium.org/2137463003/diff/1/extensions/common/features/...
File extensions/common/features/simple_feature.cc (right):

https://codereview.chromium.org/2137463003/diff/1/extensions/common/features/...
extensions/common/features/simple_feature.cc:303: std::map<std::string,
version_info::Channel> channels;
On 2016/07/12 00:35:13, lazyboy wrote:
> nit: any reason this is here and not after |platforms|? (same order we
> initialize this in the ctor).

Nope, moved.

https://codereview.chromium.org/2137463003/diff/1/extensions/common/features/...
extensions/common/features/simple_feature.cc:430: if (channel_ && *channel_ <
GetCurrentChannel()) {
On 2016/07/12 00:35:13, lazyboy wrote:
> nit: drop {}

Done.

[Devlin, 2016-07-12 19:11:09]

[email protected] changed reviewers:
+ [email protected]

[Devlin, 2016-07-12 19:11:10]

+thakis.  Need an OWNER of components/version_info to add it as a dep to
//extensions.

[Nico, 2016-07-12 19:42:38]

deps lgtm

[Devlin, 2016-07-13 16:40:37]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 16:41:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 17:10:39]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-07-13 17:10:40]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Devlin, 2016-07-13 18:50:33]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 18:51:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 19:26:13]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-07-13 19:26:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2016-07-13 19:56:58]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 19:58:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2016-07-13 20:29:52]

Patchset #4 (id:60001) has been deleted

[Devlin, 2016-07-13 20:31:10]

lazyboy@, mind taking a quick look at the delta from patch set 3?  Automatically
checking the channel was causing failures in extension shell tests since we
don't set the channel in the renderer.  I think this should be temporary and
fixed with https://codereview.chromium.org/2141703003/, but didn't want to roll
the two CLs together (since this one's already pretty giant).

[lazyboy, 2016-07-13 21:06:13]

patchset #3 -> #4 LGTM

[commit-bot: I haz the power, 2016-07-13 21:06:13]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-07-13 21:06:14]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-07-13 21:10:28]

The CQ bit was checked by [email protected]

[Devlin, 2016-07-13 21:10:28]

The patchset sent to the CQ was uploaded after l-g-t-m from [email protected]
Link to the patchset: https://codereview.chromium.org/2137463003/#ps80001
(title: "Test fix")

[commit-bot: I haz the power, 2016-07-13 21:11:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 21:24:51]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-07-13 21:28:06]

Description was changed from

==========
[Extensions] Move Feature channel code into //extensions

Channel code used to be in //chrome, so it couldn't be used in
//extensions.  Now that it's moved to components/, we can safely
include it and can simplify Features code significantly.

BUG=626774
==========

to

==========
[Extensions] Move Feature channel code into //extensions

Channel code used to be in //chrome, so it couldn't be used in
//extensions.  Now that it's moved to components/, we can safely
include it and can simplify Features code significantly.

BUG=626774

Committed: https://crrev.com/4122753620f4aa139b0606912a00491733a59b65
Cr-Commit-Position: refs/heads/master@{#405285}
==========

[commit-bot: I haz the power, 2016-07-13 21:28:08]

Patchset 4 (id:??) landed as
https://crrev.com/4122753620f4aa139b0606912a00491733a59b65
Cr-Commit-Position: refs/heads/master@{#405285}