Move registration of Java mojo interfaces to the new InterfaceRegistrar.

Move registration of Java mojo interfaces to the new InterfaceRegistrar.

Previously, Java-implemented mojo interfaces were registered on the C++
InterfaceRegistries via JNI. This CL migrates those registrations to
dedicated Java InterfaceRegistries that C++ code can access via
corresponding InterfaceProviders.

BUG=634568, 637174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2
Committed: https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3
Cr-Original-Commit-Position: refs/heads/master@{#421403}
Cr-Commit-Position: refs/heads/master@{#421711}

[Sam McNally, 2016-08-05 02:27:18]

Description was changed from

==========
Move registration of Java mojo interfaces to the new InterfaceRegistrar.

BUG=634568
==========

to

==========
Move registration of Java mojo interfaces to the new InterfaceRegistrar.

BUG=634568
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Sam McNally, 2016-08-05 02:27:58]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 02:28:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 03:36:42]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-08-05 03:36:43]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-08-05 05:15:02]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 05:15:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-08-05 05:17:05]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-08-05 06:06:23]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-08-05 06:06:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sam McNally, 2016-08-05 06:22:22]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 06:22:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 07:25:01]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-08-05 07:25:02]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-08-10 05:54:27]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 05:54:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 07:10:18]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-08-10 07:10:19]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-08-12 03:26:38]

Patchset #1 (id:20001) has been deleted

[Sam McNally, 2016-08-12 03:26:48]

Patchset #1 (id:40001) has been deleted

[Sam McNally, 2016-08-12 04:11:43]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 04:12:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-08-12 04:13:02]

Patchset #1 (id:60001) has been deleted

[Sam McNally, 2016-08-12 04:44:38]

Description was changed from

==========
Move registration of Java mojo interfaces to the new InterfaceRegistrar.

BUG=634568
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Move registration of Java mojo interfaces to the new InterfaceRegistrar.

BUG=634568, 637174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-08-12 05:14:44]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-08-12 05:14:45]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-08-29 00:28:53]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 00:29:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 00:32:19]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-08-29 00:32:20]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Sam McNally, 2016-08-29 00:37:39]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 00:37:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 01:27:35]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-08-29 01:27:36]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Sam McNally, 2016-09-19 05:35:09]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 05:35:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-09-19 06:44:08]

Patchset #1 (id:80001) has been deleted

[Sam McNally, 2016-09-19 06:44:20]

Patchset #1 (id:100001) has been deleted

[Sam McNally, 2016-09-19 06:44:31]

Patchset #1 (id:120001) has been deleted

[Sam McNally, 2016-09-19 06:57:43]

Patchset #2 (id:160001) has been deleted

[Sam McNally, 2016-09-19 07:28:53]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 07:29:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-09-19 07:30:08]

Patchset #2 (id:180001) has been deleted

[Sam McNally, 2016-09-19 07:32:17]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 07:32:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 08:49:17]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-09-19 08:49:18]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-09-20 22:03:07]

Patchset #1 (id:140001) has been deleted

[Sam McNally, 2016-09-20 22:22:46]

[email protected] changed reviewers:
+ [email protected]

[Ken Rockot(use gerrit already), 2016-09-21 14:11:39]

LGTM - this is great.

My only nit would be maybe to call it MakeInterfaceFactory or
CreateInterfaceFactory instead of GetInterfaceFactory, and to document that
method because it definitely requires a bit of thought to understand otherwise.

[Sam McNally, 2016-09-21 23:56:49]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 23:57:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-09-22 00:01:23]

[email protected] changed reviewers:
+ [email protected]

[Sam McNally, 2016-09-22 00:01:23]

+jam for //chrome and //content

On 2016/09/21 14:11:39, Ken Rockot wrote:
> LGTM - this is great.
> 
> My only nit would be maybe to call it MakeInterfaceFactory or
> CreateInterfaceFactory instead of GetInterfaceFactory, and to document that
> method because it definitely requires a bit of thought to understand
otherwise.

Done.

[commit-bot: I haz the power, 2016-09-22 01:15:37]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-09-22 01:15:38]

Dry run: This issue passed the CQ dry run.

[jam, 2016-09-22 03:48:47]

On 2016/09/22 00:01:23, Sam McNally wrote:
> +jam for //chrome and //content

I'm not really familiar with Android, so please pick owners who are. i.e. boliu
for content/browser and other owners for content/public/android and
chrome/android and chrome/browser/android.

[Sam McNally, 2016-09-22 03:54:35]

[email protected] changed reviewers:
- [email protected]

[Sam McNally, 2016-09-22 04:00:09]

[email protected] changed reviewers:
+ [email protected], [email protected]

[Sam McNally, 2016-09-22 04:00:09]

+boliu for //content/browser

+dtrainor for *android*

[boliu, 2016-09-22 14:32:18]

can you write a better CL description?

https://codereview.chromium.org/2214383002/diff/220001/content/public/android...
File
content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrar.java
(right):

https://codereview.chromium.org/2214383002/diff/220001/content/public/android...
content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrar.java:17:
class InterfaceRegistrar {
this looks empty now, can this be removed?

https://codereview.chromium.org/2214383002/diff/220001/content/public/android...
File
content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrarImpl.java
(right):

https://codereview.chromium.org/2214383002/diff/220001/content/public/android...
content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrarImpl.java:41:
static {
static blocks executes when the class is loaded by the jvm, and afaict, the only
thing loading this class is from these @CalledByNative methods. Is it possible
to just do this lazily from one of the CalledByNative methods? This is to avoid
having this run some other time if something else ends up loading this class

https://codereview.chromium.org/2214383002/diff/220001/content/public/android...
content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrarImpl.java:48:
class ContentContextInterfaceRegistrar implements InterfaceRegistrar<Context> {
question, not really about this CL

<Context> means this interface has the lifetime of the Context? It says
applicationContext below, so that implies these interfaces are global, and never
cleaned up on android?

https://codereview.chromium.org/2214383002/diff/220001/content/public/android...
content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrarImpl.java:65:
// TODO(sammc): Move this into its own file.
why wait? you are moving this code in this CL already, just move it to its final
location?

[Sam McNally, 2016-09-22 23:52:31]

Patchset #4 (id:260001) has been deleted

[Sam McNally, 2016-09-22 23:52:39]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 23:53:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 23:56:51]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-09-22 23:56:52]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Sam McNally, 2016-09-23 01:03:03]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 01:03:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-09-23 01:27:57]

Description was changed from

==========
Move registration of Java mojo interfaces to the new InterfaceRegistrar.

BUG=634568, 637174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Move registration of Java mojo interfaces to the new InterfaceRegistrar.

Previously, Java-implemented mojo interfaces were registered on the C++
InterfaceRegistries via JNI. This CL migrates those registrations to
dedicated Java InterfaceRegistries that C++ code can access via
corresponding InterfaceProviders.

BUG=634568, 637174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Sam McNally, 2016-09-23 01:38:50]

https://codereview.chromium.org/2214383002/diff/220001/content/public/android...
File
content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrar.java
(right):

https://codereview.chromium.org/2214383002/diff/220001/content/public/android...
content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrar.java:17:
class InterfaceRegistrar {
On 2016/09/22 14:32:18, boliu wrote:
> this looks empty now, can this be removed?

Yes. I was going to delete it in a follow up CL:
https://codereview.chromium.org/2217013002/.

https://codereview.chromium.org/2214383002/diff/220001/content/public/android...
File
content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrarImpl.java
(right):

https://codereview.chromium.org/2214383002/diff/220001/content/public/android...
content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrarImpl.java:41:
static {
On 2016/09/22 14:32:18, boliu wrote:
> static blocks executes when the class is loaded by the jvm, and afaict, the
only
> thing loading this class is from these @CalledByNative methods. Is it possible
> to just do this lazily from one of the CalledByNative methods? This is to
avoid
> having this run some other time if something else ends up loading this class

Done.

https://codereview.chromium.org/2214383002/diff/220001/content/public/android...
content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrarImpl.java:48:
class ContentContextInterfaceRegistrar implements InterfaceRegistrar<Context> {
On 2016/09/22 14:32:18, boliu wrote:
> question, not really about this CL
> 
> <Context> means this interface has the lifetime of the Context? It says
> applicationContext below, so that implies these interfaces are global, and
never
> cleaned up on android?

Potentially yes; the interface lifetimes are controlled by the client. In
practice, the interface impls will usually live until the webpage, RenderFrame
or renderer process that requested it goes away.

https://codereview.chromium.org/2214383002/diff/220001/content/public/android...
content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrarImpl.java:65:
// TODO(sammc): Move this into its own file.
On 2016/09/22 14:32:18, boliu wrote:
> why wait? you are moving this code in this CL already, just move it to its
final
> location?

Done.

[boliu, 2016-09-23 02:02:40]

content lgtm

[commit-bot: I haz the power, 2016-09-23 02:48:32]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2016-09-23 02:48:33]

Dry run: This issue passed the CQ dry run.

[David Trainor- moved to gerrit, 2016-09-26 18:44:00]

*android* lgtm.  Thanks!  Sorry for the delayed review.

[Sam McNally, 2016-09-26 23:40:23]

[email protected] changed reviewers:
+ [email protected]

[Sam McNally, 2016-09-26 23:40:24]

+jam for chrome/browser/DEPS

[jam, 2016-09-27 16:02:12]

lgtm

[Sam McNally, 2016-09-27 23:27:56]

The CQ bit was checked by [email protected] to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 23:28:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-09-28 00:09:19]

The CQ bit was unchecked by [email protected]

[Sam McNally, 2016-09-28 00:09:30]

The CQ bit was checked by [email protected]

[Sam McNally, 2016-09-28 00:09:31]

The patchset sent to the CQ was uploaded after l-g-t-m from [email protected]
Link to the patchset: https://codereview.chromium.org/2214383002/#ps300001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-28 00:09:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 00:53:22]

Committed patchset #5 (id:300001)

[commit-bot: I haz the power, 2016-09-28 00:56:35]

Description was changed from

==========
Move registration of Java mojo interfaces to the new InterfaceRegistrar.

Previously, Java-implemented mojo interfaces were registered on the C++
InterfaceRegistries via JNI. This CL migrates those registrations to
dedicated Java InterfaceRegistries that C++ code can access via
corresponding InterfaceProviders.

BUG=634568, 637174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Move registration of Java mojo interfaces to the new InterfaceRegistrar.

Previously, Java-implemented mojo interfaces were registered on the C++
InterfaceRegistries via JNI. This CL migrates those registrations to
dedicated Java InterfaceRegistries that C++ code can access via
corresponding InterfaceProviders.

BUG=634568, 637174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2
Cr-Commit-Position: refs/heads/master@{#421403}
==========

[commit-bot: I haz the power, 2016-09-28 00:56:37]

Patchset 5 (id:??) landed as
https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2
Cr-Commit-Position: refs/heads/master@{#421403}

[David Trainor- moved to gerrit, 2016-09-28 21:21:53]

A revert of this CL (patchset #5 id:300001) has been created in
https://codereview.chromium.org/2374213002/ by [email protected].

The reason for reverting is: Looks like I have to revert this :(.  Breaking the
Chromium Android FYI bot.  Basically Android doesn't actually include or build
any native code from device/battery.  It also doesn't depend on and build
battery_monitor.mojom for certain targets.  Sorry!

See compile failures here:
https://build.chromium.org/p/chromium.fyi/builders/Android%20Builder%20(dbg)

gn args to reproduce:
enable_vr_shell = true
ffmpeg_branding = "Chrome"
is_component_build = false
is_debug = true
proprietary_codecs = true
symbol_level = 1
target_os = "android"
use_goma = true

build targets to reproduce:
chrome/browser/android/vr_shell
chrome/browser/android/vr_shell:vr_shell_unittests.

[boliu, 2016-09-28 21:29:53]

https://codereview.chromium.org/2214383002/diff/300001/content/browser/BUILD.gn
File content/browser/BUILD.gn (right):

https://codereview.chromium.org/2214383002/diff/300001/content/browser/BUILD....
content/browser/BUILD.gn:1763: deps -= [ "//device/battery" ]
ahh, should remove this line?

why did the other bots pass? o_O

[David Trainor- moved to gerrit, 2016-09-28 21:52:29]

On 2016/09/28 21:29:53, boliu wrote:
>
https://codereview.chromium.org/2214383002/diff/300001/content/browser/BUILD.gn
> File content/browser/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2214383002/diff/300001/content/browser/BUILD....
> content/browser/BUILD.gn:1763: deps -= [ "//device/battery" ]
> ahh, should remove this line?
> 
> why did the other bots pass? o_O

Not quite sure :(.  Maybe a combination of gn configs, component builds, and
target ordering?  But yeah I was surprised as well...

[Sam McNally, 2016-09-29 00:12:07]

Description was changed from

==========
Move registration of Java mojo interfaces to the new InterfaceRegistrar.

Previously, Java-implemented mojo interfaces were registered on the C++
InterfaceRegistries via JNI. This CL migrates those registrations to
dedicated Java InterfaceRegistries that C++ code can access via
corresponding InterfaceProviders.

BUG=634568, 637174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2
Cr-Commit-Position: refs/heads/master@{#421403}
==========

to

==========
Move registration of Java mojo interfaces to the new InterfaceRegistrar.

Previously, Java-implemented mojo interfaces were registered on the C++
InterfaceRegistries via JNI. This CL migrates those registrations to
dedicated Java InterfaceRegistries that C++ code can access via
corresponding InterfaceProviders.

BUG=634568, 637174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2
Cr-Commit-Position: refs/heads/master@{#421403}
==========

[Sam McNally, 2016-09-29 00:12:56]

Patchset #6 (id:320001) has been deleted

[Sam McNally, 2016-09-29 00:17:38]

On 2016/09/28 21:52:29, David Trainor wrote:
> On 2016/09/28 21:29:53, boliu wrote:
> >
>
https://codereview.chromium.org/2214383002/diff/300001/content/browser/BUILD.gn
> > File content/browser/BUILD.gn (right):
> > 
> >
>
https://codereview.chromium.org/2214383002/diff/300001/content/browser/BUILD....
> > content/browser/BUILD.gn:1763: deps -= [ "//device/battery" ]
> > ahh, should remove this line?

It's not quite that simple. On Android //device/battery doesn't exist and we
only need //device/battery:mojo_bindings.
> > 
> > why did the other bots pass? o_O
> 
> Not quite sure :(.  Maybe a combination of gn configs, component builds, and
> target ordering?  But yeah I was surprised as well...

Some targets happen to find it through //content/renderer:
//content/shell/android:content_shell_apk --[public]-->
//content/shell/android:content_shell_apk__create --[public]-->
//content/shell/android:content_shell_apk__create__finalize --[public]-->
//content/shell/android:content_shell_apk__create__package --[private]-->
//content/shell/android:libcontent_shell_content_view --[private]-->
//components/crash/content/browser:browser --[private]-->
//content/public/browser:browser --[public]-->
//content:content --[public]-->
//content/public/renderer:renderer_sources --[private]-->
//content/renderer:renderer --[private]-->
//device/battery:mojo_bindings

//content/shell/android:content_shell_apk --[public]-->
//content/shell/android:content_shell_apk__create --[public]-->
//content/shell/android:content_shell_apk__create__finalize --[public]-->
//content/shell/android:content_shell_apk__create__package --[private]-->
//content/shell/android:libcontent_shell_content_view --[private]-->
//content/shell:content_shell_lib --[public]-->
//content/public/app:both --[private]-->
//content/public/renderer:renderer_sources --[private]-->
//content/renderer:renderer --[private]-->
//device/battery:mojo_bindings

I think //content/renderer depending on //device/battery:mojo_bindings isn't
needed now, since the renderer side has moved into blink.

Adding a dependency from //content/browser on //device/battery:mojo_bindings
fixes vr_shell locally.

[Sam McNally, 2016-09-29 00:17:54]

The CQ bit was checked by [email protected]

[Sam McNally, 2016-09-29 00:17:54]

The patchset sent to the CQ was uploaded after l-g-t-m from [email protected],
[email protected], [email protected], [email protected]
Link to the patchset: https://codereview.chromium.org/2214383002/#ps360001
(title: "fix vr_shell build")

[commit-bot: I haz the power, 2016-09-29 00:18:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 01:49:35]

Description was changed from

==========
Move registration of Java mojo interfaces to the new InterfaceRegistrar.

Previously, Java-implemented mojo interfaces were registered on the C++
InterfaceRegistries via JNI. This CL migrates those registrations to
dedicated Java InterfaceRegistries that C++ code can access via
corresponding InterfaceProviders.

BUG=634568, 637174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2
Cr-Commit-Position: refs/heads/master@{#421403}
==========

to

==========
Move registration of Java mojo interfaces to the new InterfaceRegistrar.

Previously, Java-implemented mojo interfaces were registered on the C++
InterfaceRegistries via JNI. This CL migrates those registrations to
dedicated Java InterfaceRegistries that C++ code can access via
corresponding InterfaceProviders.

BUG=634568, 637174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2
Cr-Commit-Position: refs/heads/master@{#421403}
==========

[commit-bot: I haz the power, 2016-09-29 01:49:37]

Committed patchset #7 (id:360001)

[commit-bot: I haz the power, 2016-09-29 01:51:56]

Description was changed from

==========
Move registration of Java mojo interfaces to the new InterfaceRegistrar.

Previously, Java-implemented mojo interfaces were registered on the C++
InterfaceRegistries via JNI. This CL migrates those registrations to
dedicated Java InterfaceRegistries that C++ code can access via
corresponding InterfaceProviders.

BUG=634568, 637174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2
Cr-Commit-Position: refs/heads/master@{#421403}
==========

to

==========
Move registration of Java mojo interfaces to the new InterfaceRegistrar.

Previously, Java-implemented mojo interfaces were registered on the C++
InterfaceRegistries via JNI. This CL migrates those registrations to
dedicated Java InterfaceRegistries that C++ code can access via
corresponding InterfaceProviders.

BUG=634568, 637174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/58dcb20da65389d841cd02d9197fb43efb6e8ee2
Committed: https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3
Cr-Original-Commit-Position: refs/heads/master@{#421403}
Cr-Commit-Position: refs/heads/master@{#421711}
==========

[commit-bot: I haz the power, 2016-09-29 01:51:58]

Patchset 7 (id:??) landed as
https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3
Cr-Commit-Position: refs/heads/master@{#421711}