|
|
DescriptionUpdate the description strings for the new omnibox verbose states.
Also adds `meaning=` tags so that the strings are translated separately for this exact context.
BUG=645290
Committed: https://crrev.com/4f1f3f1563dfcbd6156aad69eedded4f8e85e2e6
Cr-Commit-Position: refs/heads/master@{#419530}
Patch Set 1 #Patch Set 2 : Describe as "adjective" (more specific than "word"). #Patch Set 3 : Rebase. #Messages
Total messages: 27 (13 generated)
[email protected] changed reviewers: + [email protected]
felt@, could you review?
thank you lucas! lgtm
Description was changed from ========== Update the description strings for the new omnibox verbose states. Also adds `meaning=` tags so that the strings are translated seperately for this exact context. BUG=645290 ========== to ========== Update the description strings for the new omnibox verbose states. Also adds `meaning=` tags so that the strings are translated separately for this exact context. BUG=645290 ==========
The CQ bit was checked by [email protected]
The CQ bit was unchecked by [email protected]
felt@: I changed "A word or short phrase" to "An adjective or short adjective phrase". Still sound good?
still lgtm
The CQ bit was checked by [email protected]
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by [email protected]
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...) ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Patchset #3 (id:40001) has been deleted
The CQ bit was checked by [email protected]
The patchset sent to the CQ was uploaded after l-g-t-m from [email protected] Link to the patchset: https://codereview.chromium.org/2342683002/#ps60001 (title: "Rebase.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by [email protected]
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
[email protected] changed reviewers: + [email protected]
jochen@, could you ONWERS-review? Also, any reason this file isn't editable by anyone (like generated_resources.grd)?
lgtm
The CQ bit was checked by [email protected]
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Update the description strings for the new omnibox verbose states. Also adds `meaning=` tags so that the strings are translated separately for this exact context. BUG=645290 ========== to ========== Update the description strings for the new omnibox verbose states. Also adds `meaning=` tags so that the strings are translated separately for this exact context. BUG=645290 Committed: https://crrev.com/4f1f3f1563dfcbd6156aad69eedded4f8e85e2e6 Cr-Commit-Position: refs/heads/master@{#419530} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/4f1f3f1563dfcbd6156aad69eedded4f8e85e2e6 Cr-Commit-Position: refs/heads/master@{#419530} |