Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Issue 2342683002: Update the description strings for the new omnibox verbose states. (Closed)

Created:
4 years, 3 months ago by lgarron
Modified:
4 years, 3 months ago
CC:
ainslie, chromium-reviews, maxwalker, palmer
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the description strings for the new omnibox verbose states. Also adds `meaning=` tags so that the strings are translated separately for this exact context. BUG=645290 Committed: https://crrev.com/4f1f3f1563dfcbd6156aad69eedded4f8e85e2e6 Cr-Commit-Position: refs/heads/master@{#419530}

Patch Set 1 #

Patch Set 2 : Describe as "adjective" (more specific than "word"). #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M components/omnibox_strings.grdp View 1 2 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 27 (13 generated)
lgarron
felt@, could you review?
4 years, 3 months ago (2016-09-14 21:47:23 UTC) #2
felt
thank you lucas! lgtm
4 years, 3 months ago (2016-09-15 00:04:08 UTC) #3
lgarron
felt@: I changed "A word or short phrase" to "An adjective or short adjective phrase". ...
4 years, 3 months ago (2016-09-15 00:14:27 UTC) #7
felt
still lgtm
4 years, 3 months ago (2016-09-15 00:16:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342683002/20001
4 years, 3 months ago (2016-09-15 00:20:39 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/30923) ios-device on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 3 months ago (2016-09-15 00:25:13 UTC) #12
lgarron
4 years, 3 months ago (2016-09-15 02:27:06 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342683002/60001
4 years, 3 months ago (2016-09-15 21:04:04 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/260520)
4 years, 3 months ago (2016-09-15 21:14:29 UTC) #19
lgarron
jochen@, could you ONWERS-review? Also, any reason this file isn't editable by anyone (like generated_resources.grd)?
4 years, 3 months ago (2016-09-15 21:49:03 UTC) #21
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-19 14:22:53 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342683002/60001
4 years, 3 months ago (2016-09-19 19:09:33 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 3 months ago (2016-09-19 19:24:16 UTC) #25
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 21:03:04 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4f1f3f1563dfcbd6156aad69eedded4f8e85e2e6
Cr-Commit-Position: refs/heads/master@{#419530}

Powered by Google App Engine
This is Rietveld 408576698