Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 257001: Hook up webkit/api/public/WebView.h... (Closed)

Created:
11 years, 2 months ago by darin (slow to review)
Modified:
9 years, 7 months ago
Reviewers:
dglazkov
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, Erik does not do reviews, jam, pam+watch_chromium.org, Paweł Hajdan Jr., darin (slow to review), tim (not reviewing)
Visibility:
Public.

Description

Hook up webkit/api/public/WebView.h This change does not completely eliminate webkit/glue/webview.h. Instead, the old WebView extends from the new WebView temporarily as we complete the transition. R=dglazkov BUG=10033 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27620

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+391 lines, -511 lines) Patch
M chrome/renderer/extensions/extension_process_bindings.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/print_web_view_helper.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 56 chunks +73 lines, -75 lines 0 comments Download
M chrome/renderer/render_view_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/render_view_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/api/public/WebView.h View 7 chunks +29 lines, -39 lines 0 comments Download
M webkit/glue/chrome_client_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webkit/glue/cpp_bound_class_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/dom_operations.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M webkit/glue/dom_serializer_unittest.cc View 8 chunks +9 lines, -12 lines 0 comments Download
M webkit/glue/iframe_redirect_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/mimetype_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/resource_fetcher_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/glue/webaccessibilitymanager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webdevtoolsagent_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webframe_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/glue/webkit_glue.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webplugin_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webpreferences.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webview.h View 1 2 4 chunks +2 lines, -109 lines 0 comments Download
M webkit/glue/webview_impl.h View 1 chunk +38 lines, -36 lines 0 comments Download
M webkit/glue/webview_impl.cc View 17 chunks +135 lines, -134 lines 0 comments Download
M webkit/glue/webworker_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webkit/tools/test_shell/drag_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/drop_delegate.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/event_sending_controller.cc View 5 chunks +18 lines, -20 lines 0 comments Download
M webkit/tools/test_shell/layout_test_controller.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M webkit/tools/test_shell/plugin_tests.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M webkit/tools/test_shell/test_shell_gtk.cc View 2 3 3 chunks +3 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate_gtk.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/text_input_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/webkit.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
darin (slow to review)
11 years, 2 months ago (2009-09-30 07:39:21 UTC) #1
dglazkov
11 years, 2 months ago (2009-09-30 16:25:54 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698