chrome/browser cleanup: Splitting ProfileImpl out of profile.cc.

Split ProfileImpl out of profile.cc.

This is a relatively trivial change which moves ProfileImpl into a separate file to avoid depending on its implementation. The fact that no code references ProfileImpl implies that it doesn't need to be public anyway.

Does not affect OffTheRecordProfile, since its dependencies are relatively minimal.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54409

[Patrick Horn, 2010-07-28 23:52:13]

Currently it is fairly non-trivial to embed Chromium in an existing application,
such as ChromeFrame or my side project at berkelium.org, without essentially
needing to link to the entire chrome.dll when they really only need the
tab_contents or renderer_host layers.

This is the first of a set of cleanups I intend to make which hopefully will
remove some dependencies of browser/tab_contents on browser.

In this commit, although ProfileImpl was declared inside profile.h, no code
depends on the implementation. I wanted to move this into a different file to
enforce this.

My next step will be to make a ProfileFactory and remove Profile::Create (used
by ProfileManager), which would allow applications to use their own Profile
class rather than the default.

Then, over time it could be to provide alternate implementations of a Profile,
one of which could be to return NULL or stubbed out implementations of the
classes returned by Profile (many of which are already virtual). This would
allow us to reduce link dependencies to implementations of browser components
and everything that they pull in.

I'm very interested on comments about this approach, or if there are better ways
to achieve what I am trying to do.

[brettw, 2010-07-30 18:40:14]

LGTM

http://codereview.chromium.org/2806087/diff/1/2
File chrome/browser/profile.cc (right):

http://codereview.chromium.org/2806087/diff/1/2#newcode92
chrome/browser/profile.cc:92: #include
"chrome/browser/background_contents_service.h"
Crazy, why on earth were these in the middle of the file?!?! Can you move these
includes to the top while you're changing this stuff around?

[Patrick Horn, 2010-07-30 22:11:19]

brettw, could you take one more look after I rebased and moved the headers?

[brettw, 2010-07-30 22:46:54]

LGTM