Create the extensions (<Profile>/Extensions) and user script (<Profile>/User ...

Create the extensions (<Profile>/Extensions) and user script (<Profile>/User Scripts) directories during start up if they don't already exists


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10134

[rafaelw, 2009-02-20 20:14:55]

Hey Guys,

Here's the new CL that's doesn't against a real source tree, has Matt's
correction (indent size), and Aaron's request to add the User Scripts directory.

[Aaron Boodman, 2009-02-20 20:29:01]

http://codereview.chromium.org/29001/diff/2002/1003
File chrome/browser/extensions/extensions_service.cc (right):

http://codereview.chromium.org/29001/diff/2002/1003#newcode167
Line 167: // Create the <Profile>/Extensions directory if it doesn't exist
Indent the comment to match the line below. And add a period :).

http://codereview.chromium.org/29001/diff/2002/1003#newcode168
Line 168: if (!file_util::DirectoryExists(path))
This should probably be after the AbsolutePath() sanity check below.

[Matt Perry, 2009-02-20 20:32:21]

http://codereview.chromium.org/29001/diff/2002/1003
File chrome/browser/extensions/extensions_service.cc (right):

http://codereview.chromium.org/29001/diff/2002/1003#newcode164
Line 164: 
kill extra newline

http://codereview.chromium.org/29001/diff/2002/1003#newcode167
Line 167: // Create the <Profile>/Extensions directory if it doesn't exist
indent

http://codereview.chromium.org/29001/diff/2002/1003#newcode168
Line 168: if (!file_util::DirectoryExists(path))
On 2009/02/20 20:29:01, Aaron Boodman wrote:
> This should probably be after the AbsolutePath() sanity check below.

I think AbsolutePath fails if the directory doesn't exist.

[Aaron Boodman, 2009-02-20 20:42:21]

http://codereview.chromium.org/29001/diff/2002/1003
File chrome/browser/extensions/extensions_service.cc (right):

http://codereview.chromium.org/29001/diff/2002/1003#newcode168
Line 168: if (!file_util::DirectoryExists(path))
On 2009/02/20 20:32:22, Matt Perry wrote:
> On 2009/02/20 20:29:01, Aaron Boodman wrote:
> > This should probably be after the AbsolutePath() sanity check below.
> 
> I think AbsolutePath fails if the directory doesn't exist.
> 

Ok.

[rafaelw, 2009-02-20 21:12:52]

http://codereview.chromium.org/29001/diff/2002/1003
File chrome/browser/extensions/extensions_service.cc (right):

http://codereview.chromium.org/29001/diff/2002/1003#newcode164
Line 164: 
On 2009/02/20 20:32:22, Matt Perry wrote:
> kill extra newline

Done.

http://codereview.chromium.org/29001/diff/2002/1003#newcode167
Line 167: // Create the <Profile>/Extensions directory if it doesn't exist
On 2009/02/20 20:29:01, Aaron Boodman wrote:
> Indent the comment to match the line below. And add a period :).

Done.

http://codereview.chromium.org/29001/diff/2002/1003#newcode167
Line 167: // Create the <Profile>/Extensions directory if it doesn't exist
On 2009/02/20 20:32:22, Matt Perry wrote:
> indent

Done.

[Aaron Boodman, 2009-02-20 21:40:12]

LGTM

[Matt Perry, 2009-02-20 21:40:40]

LGTM

[Dean McNamee, 2009-02-21 13:52:46]

What thread does this happen on?  Just curious, trying to keep file system
access off the startup critical path if possible.  This adds two directory
checks on startup.

On 2009/02/20 21:40:40, Matt Perry wrote:
> LGTM