Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 2908643003: [mus+ash] Removes WmWindow from ash/wm/focus_rules (Closed)

Created:
3 years, 7 months ago by varkha
Modified:
3 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[mus+ash] Removes WmWindow from ash/wm/focus_rules With this CL WmWindow is no longer used in ash/wm. BUG=722553 TEST=None (refactoring) Review-Url: https://codereview.chromium.org/2908643003 Cr-Commit-Position: refs/heads/master@{#475121} Committed: https://chromium.googlesource.com/chromium/src/+/d43f552484b80d116b5e07960d2565e3399d67c0

Patch Set 1 #

Patch Set 2 : [mus+ash] Removes WmWindow from ash/wm/focus_rules (rebased) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M ash/mus/shell_delegate_mus.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/mus/shell_delegate_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/shell_delegate_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell_delegate.h View 3 chunks +5 lines, -2 lines 0 comments Download
M ash/test/test_shell_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_shell_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/focus_rules.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (5 generated)
varkha
sky@, can you please take a look? This still needs https://codereview.chromium.org/2908793002/ to land first. Thanks!
3 years, 7 months ago (2017-05-26 18:22:08 UTC) #2
sky
LGTM
3 years, 7 months ago (2017-05-26 19:12:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908643003/20001
3 years, 7 months ago (2017-05-26 20:15:01 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 20:56:21 UTC) #9

Powered by Google App Engine
This is Rietveld 408576698