Issue 3492008: Fix a bug in the string wrapper for SHA256HashString.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3492008: Fix a bug in the string wrapper for SHA256HashString. (Closed)

Created:
10 years, 3 months ago by Brian Ryner

Modified:
9 years, 7 months ago

Reviewers:
lzheng, noelutz

CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org, chrome-anti-phishing_googlegroups.com

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Fix a bug in the string wrapper for SHA256HashString. The wrapper was using the size of the input string as the number of hash bytes to compute, rather than the size of the output string (SHA256_LENGTH). Added a test for this. BUG=none TEST=Sha256Test.Test1_String Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60491

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -1 line)			Patch
	M	base/sha2.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	base/sha2_unittest.cc	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Brian Ryner

Just fyi, this wasn't actually causing any problems in Chrome. This version of SHA256HashString is ...

10 years, 3 months ago (2010-09-24 03:45:14 UTC) #2

lgtm