Geolocation dispatcher rename:

Geolocation dispatcher rename:

Rename GeolocationDispatcherHost to GeolocationDispatcherHostOld and GeolocationDispatcher to GeolocationDispatcherOld in preparation for the new client-based implementation.

BUG=59908
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63507

[bulach, 2010-10-19 19:03:48]

LGTM

overall looks fine, a few nits below and one suggestion:
Since this is a multi-step change, it'd be nice to add a meta-bug on crbug.com
to keep track of it (and the associated WebKit bugs).

Then, we can add the bug id here and subsequent patches, and also a reference to
it in the code.

http://codereview.chromium.org/3799010/diff/1/2
File chrome/browser/geolocation/geolocation_dispatcher_host_old.cc (right):

http://codereview.chromium.org/3799010/diff/1/2#newcode131
chrome/browser/geolocation/geolocation_dispatcher_host_old.cc:131: void
GeolocationDispatcherHostOldImpl::OnRegisterDispatcher(int render_view_id) {
>80cols

http://codereview.chromium.org/3799010/diff/1/2#newcode137
chrome/browser/geolocation/geolocation_dispatcher_host_old.cc:137: void
GeolocationDispatcherHostOldImpl::OnUnregisterDispatcher(int render_view_id) {
>80cols

http://codereview.chromium.org/3799010/diff/1/2#newcode228
chrome/browser/geolocation/geolocation_dispatcher_host_old.cc:228: return new
GeolocationDispatcherHostOldImpl(resource_message_filter_process_id,
>80cols

http://codereview.chromium.org/3799010/diff/1/11
File chrome/renderer/geolocation_dispatcher_old.h (right):

http://codereview.chromium.org/3799010/diff/1/11#newcode21
chrome/renderer/geolocation_dispatcher_old.h:21: // It's the complement of
GeolocationDispatcherOldHost (owned by RenderViewHost).
>80cols.

also, it'd be great to add the same TODO as the host:

// TODO(jknotten): Remove this class once the new client-based implementation is
// checked in (see https://bugs.webkit.org/show_bug.cgi?id=45752).

[John Knottenbelt, 2010-10-20 09:49:11]

http://codereview.chromium.org/3799010/diff/1/2
File chrome/browser/geolocation/geolocation_dispatcher_host_old.cc (right):

http://codereview.chromium.org/3799010/diff/1/2#newcode131
chrome/browser/geolocation/geolocation_dispatcher_host_old.cc:131: void
GeolocationDispatcherHostOldImpl::OnRegisterDispatcher(int render_view_id) {
On 2010/10/19 19:03:49, bulach wrote:
> >80cols

Done.

http://codereview.chromium.org/3799010/diff/1/2#newcode137
chrome/browser/geolocation/geolocation_dispatcher_host_old.cc:137: void
GeolocationDispatcherHostOldImpl::OnUnregisterDispatcher(int render_view_id) {
On 2010/10/19 19:03:49, bulach wrote:
> >80cols

Done.

http://codereview.chromium.org/3799010/diff/1/2#newcode228
chrome/browser/geolocation/geolocation_dispatcher_host_old.cc:228: return new
GeolocationDispatcherHostOldImpl(resource_message_filter_process_id,
On 2010/10/19 19:03:49, bulach wrote:
> >80cols

Done.

http://codereview.chromium.org/3799010/diff/1/11
File chrome/renderer/geolocation_dispatcher_old.h (right):

http://codereview.chromium.org/3799010/diff/1/11#newcode21
chrome/renderer/geolocation_dispatcher_old.h:21: // It's the complement of
GeolocationDispatcherOldHost (owned by RenderViewHost).
On 2010/10/19 19:03:49, bulach wrote:
> >80cols.
> 
> also, it'd be great to add the same TODO as the host:
> 
> // TODO(jknotten): Remove this class once the new client-based implementation
is
> // checked in (see https://bugs.webkit.org/show_bug.cgi?id=45752).

Done.