components: Update GN build files for crx_file.

components: Update GN build files for crx_file.

This adds BUILD.gn files for crx_file component. This was overlooked when I originally created the crx_file component.

BUG=371463
[email protected]

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290455

[tommycli, 2014-08-19 00:11:48]

thestig: Mind reviewing this small thing since the components/ OWNERs are both
OOO?

[Lei Zhang, 2014-08-19 00:19:55]

You added CRX_FILE_IMPLEMENTATION to components/crx_file.gypi in r289966.
Shouldn't you add that to the GN version, or remove it from the GYP version if
it's unused?

https://codereview.chromium.org/483683004/diff/40001/components/crx_file/BUIL...
File components/crx_file/BUILD.gn (right):

https://codereview.chromium.org/483683004/diff/40001/components/crx_file/BUIL...
components/crx_file/BUILD.gn:5: source_set("crx_file") {
Shouldn't this also be static_library?

[tommycli, 2014-08-19 00:25:01]

On 2014/08/19 00:19:55, Lei Zhang wrote:
> You added CRX_FILE_IMPLEMENTATION to components/crx_file.gypi in r289966.
> Shouldn't you add that to the GN version, or remove it from the GYP version if
> it's unused?

Ah, good catch. actually I think neither should have that define, and i removed
it from the gypi. It's needed when you make it a 'component' target type so it
can export the symbols properly.

> 
>
https://codereview.chromium.org/483683004/diff/40001/components/crx_file/BUIL...
> File components/crx_file/BUILD.gn (right):
> 
>
https://codereview.chromium.org/483683004/diff/40001/components/crx_file/BUIL...
> components/crx_file/BUILD.gn:5: source_set("crx_file") {
> Shouldn't this also be static_library?

[tommycli, 2014-08-19 00:25:08]

https://codereview.chromium.org/483683004/diff/40001/components/crx_file/BUIL...
File components/crx_file/BUILD.gn (right):

https://codereview.chromium.org/483683004/diff/40001/components/crx_file/BUIL...
components/crx_file/BUILD.gn:5: source_set("crx_file") {
On 2014/08/19 00:19:54, Lei Zhang wrote:
> Shouldn't this also be static_library?

source_set is introduced as a 'virtual' static_library in GN. It's not
consistently used, but according to
https://code.google.com/p/chromium/wiki/GNLanguage, it's preferrable.

[Lei Zhang, 2014-08-19 00:29:08]

lgtm

[tommycli, 2014-08-19 00:31:12]

The CQ bit was checked by [email protected]

[tommycli, 2014-08-19 00:31:16]

On 2014/08/19 00:29:08, Lei Zhang wrote:
> lgtm

thank you sir

[commit-bot: I haz the power, 2014-08-19 00:33:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/[email protected]/483683004/60001

[commit-bot: I haz the power, 2014-08-19 02:11:00]

Committed patchset #4 (60001) as 290455