Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 48523010: [Refactor] Introduce MediaDelegate (Closed)

Created:
7 years, 1 month ago by oshima
Modified:
7 years, 1 month ago
Reviewers:
stevenjb
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -68 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M ash/accessibility_delegate.h View 1 1 chunk +0 lines, -1 line 0 comments Download
A ash/media_delegate.h View 1 1 chunk +27 lines, -0 lines 0 comments Download
M ash/new_window_delegate.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/shell.h View 3 chunks +6 lines, -0 lines 0 comments Download
M ash/shell.cc View 1 3 chunks +4 lines, -0 lines 0 comments Download
M ash/shell/shell_delegate_impl.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 4 chunks +18 lines, -9 lines 0 comments Download
M ash/shell_delegate.h View 1 2 chunks +4 lines, -9 lines 0 comments Download
M ash/test/test_shell_delegate.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M ash/test/test_shell_delegate.cc View 1 4 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc View 4 chunks +32 lines, -18 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_views.cc View 1 4 chunks +17 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
oshima
Steven, would you mind reviewing this, as the original author (sschmitz) is gone?
7 years, 1 month ago (2013-10-31 06:58:06 UTC) #1
stevenjb
lgtm w/ protected or DISALLOW https://codereview.chromium.org/48523010/diff/40001/ash/media_delegate.h File ash/media_delegate.h (right): https://codereview.chromium.org/48523010/diff/40001/ash/media_delegate.h#newcode14 ash/media_delegate.h:14: virtual ~MediaDelegate() {} Protect ...
7 years, 1 month ago (2013-10-31 20:40:03 UTC) #2
oshima
let me know if you still think i should add DISALLOW.. https://codereview.chromium.org/48523010/diff/40001/ash/media_delegate.h File ash/media_delegate.h (right): ...
7 years, 1 month ago (2013-11-01 00:30:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/48523010/120001
7 years, 1 month ago (2013-11-01 00:37:49 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-01 11:43:15 UTC) #5
Message was sent while issue was closed.
Change committed as 232330

Powered by Google App Engine
This is Rietveld 408576698