Use regular message loop for cros login window

Use regular message loop for cros login window

First we have to allow the regular initialization to happen.
This will permit the login wizard screens to use the network
and rendering capabilities of chrome safely. Once a user logs in
and cros mounts their encrypted directory as a profile, we
change the default profile to that one and create a new browser
window with it as well. This ought to make launching the
first browser window even faster.

[sky, 2010-02-16 19:22:40]

LGTM with the following changes.

http://codereview.chromium.org/604052/diff/1044/1045
File chrome/browser/browser_init.cc (right):

http://codereview.chromium.org/604052/diff/1044/1045#newcode910
chrome/browser/browser_init.cc:910: if
(command_line.HasSwitch(switches::kLoginManager))
Can you add a comment here indicating that when using the login manager we
launch after login.

http://codereview.chromium.org/604052/diff/1044/1046
File chrome/browser/browser_init.h (right):

http://codereview.chromium.org/604052/diff/1044/1046#newcode66
chrome/browser/browser_init.h:66: // empty. process_startup indicates whether
this is the first browser.
nit: in descriptions use pipes around arguments.

http://codereview.chromium.org/604052/diff/1044/1046#newcode66
chrome/browser/browser_init.h:66: // empty. process_startup indicates whether
this is the first browser.
What does an empty cur_dir mean?

http://codereview.chromium.org/604052/diff/1044/1049
File chrome/browser/chromeos/login/login_wizard_view.cc (right):

http://codereview.chromium.org/604052/diff/1044/1049#newcode99
chrome/browser/chromeos/login/login_wizard_view.cc:99: const std::string
start_screen_name, gfx::Size size) {
const gfx::Size& and it should be const std::string& too.

http://codereview.chromium.org/604052/diff/1044/1049#newcode132
chrome/browser/chromeos/login/login_wizard_view.cc:132: void
ShowLoginWizard(const std::string& start_screen_name, gfx::Size size) {
const&

http://codereview.chromium.org/604052/diff/1044/1050
File chrome/browser/chromeos/login/login_wizard_view.h (right):

http://codereview.chromium.org/604052/diff/1044/1050#newcode36
chrome/browser/chromeos/login/login_wizard_view.h:36: void Init(const
std::string& start_view_name, gfx::Size size);
const gfx::Size&

http://codereview.chromium.org/604052/diff/1044/1050#newcode85
chrome/browser/chromeos/login/login_wizard_view.h:85: // todo(davemoore) Remove
this after done.
// TODO(davemoore):

http://codereview.chromium.org/604052/diff/1044/1052
File chrome/browser/chromeos/login/test_renderer_screen.h (right):

http://codereview.chromium.org/604052/diff/1044/1052#newcode14
chrome/browser/chromeos/login/test_renderer_screen.h:14: class
TestRendererScreen : public WizardScreen {
Should this be in the chromeos namespace too?

http://codereview.chromium.org/604052/diff/1044/1052#newcode22
chrome/browser/chromeos/login/test_renderer_screen.h:22: };
DISALLOW_COPY_AND_ASSIGN

http://codereview.chromium.org/604052/diff/1044/1054
File chrome/browser/profile_manager.cc (right):

http://codereview.chromium.org/604052/diff/1044/1054#newcode89
chrome/browser/profile_manager.cc:89: // todo(davemoore) Delete this once
chromium os has started using
// TODO(davemoore):

http://codereview.chromium.org/604052/diff/1044/1055
File chrome/browser/profile_manager.h (right):

http://codereview.chromium.org/604052/diff/1044/1055#newcode155
chrome/browser/profile_manager.h:155: bool logged_in_;
Description?

http://codereview.chromium.org/604052/diff/1044/1056
File chrome/browser/views/browser_dialogs.h (right):

http://codereview.chromium.org/604052/diff/1044/1056#newcode96
chrome/browser/views/browser_dialogs.h:96: void ShowLoginWizard(const
std::string& start_screen, gfx::Size size);
const gfx::Size&

http://codereview.chromium.org/604052/diff/1044/1058
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/604052/diff/1044/1058#newcode741
chrome/common/chrome_switches.cc:741: // todo(davemoore) Delete this once
chromeos has started using
// TODO(davemoore):

http://codereview.chromium.org/604052/diff/1044/1060
File chrome/common/notification_type.h (right):

http://codereview.chromium.org/604052/diff/1044/1060#newcode851
chrome/common/notification_type.h:851: LOGIN_USER_CHANGED,
Description?