Cleanup: de-inline a bunch of classes, rename and move "PluginInstaller" to "...

Cleanup: de-inline a bunch of classes, rename and move "PluginInstaller" to "PluginInstallerInfoBarDelegate" for clarity, lots of other misc. stuff

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72166

[Peter Kasting, 2011-01-20 00:11:15]

There shouldn't be any functional changes in this.

[Elliot Glaysher, 2011-01-20 01:02:03]

LGTM++

http://codereview.chromium.org/6249010/diff/1/chrome/browser/notifications/de...
File chrome/browser/notifications/desktop_notification_service.cc (right):

http://codereview.chromium.org/6249010/diff/1/chrome/browser/notifications/de...
chrome/browser/notifications/desktop_notification_service.cc:99:
~NotificationPermissionInfoBarDelegate();
virtual, I presume?

http://codereview.chromium.org/6249010/diff/1/chrome/browser/tab_contents/tab...
File chrome/browser/tab_contents/tab_contents.cc (left):

http://codereview.chromium.org/6249010/diff/1/chrome/browser/tab_contents/tab...
chrome/browser/tab_contents/tab_contents.cc:1219: // Just to be safe, make sure
the delegate was not removed by an observer.
I assume that this safety code is obsolete?

[Peter Kasting, 2011-01-20 01:45:14]

Will submit once I can get clean(ish) try runs.

http://codereview.chromium.org/6249010/diff/1/chrome/browser/notifications/de...
File chrome/browser/notifications/desktop_notification_service.cc (right):

http://codereview.chromium.org/6249010/diff/1/chrome/browser/notifications/de...
chrome/browser/notifications/desktop_notification_service.cc:99:
~NotificationPermissionInfoBarDelegate();
On 2011/01/20 01:02:03, Elliot Glaysher wrote:
> virtual, I presume?

Good catch!

http://codereview.chromium.org/6249010/diff/1/chrome/browser/tab_contents/tab...
File chrome/browser/tab_contents/tab_contents.cc (left):

http://codereview.chromium.org/6249010/diff/1/chrome/browser/tab_contents/tab...
chrome/browser/tab_contents/tab_contents.cc:1219: // Just to be safe, make sure
the delegate was not removed by an observer.
On 2011/01/20 01:02:03, Elliot Glaysher wrote:
> I assume that this safety code is obsolete?

Yes.  There's no current code that would trip this and it would be an odd thing
to do, so I don't see a reason to pollute the function with checking for it.

[Bernhard Bauer, 2011-01-28 12:23:55]

Drive-by question: Is there a particular advantage to de-inlining classes
defined in .cc files? Is this preferred now?

[Peter Kasting, 2011-01-28 17:18:16]

On 2011/01/28 12:23:55, Bernhard Bauer wrote:
> Drive-by question: Is there a particular advantage to de-inlining classes
> defined in .cc files? Is this preferred now?

It is preferred; from http://dev.chromium.org/developers/coding-style : "Even
with a class that's local to a single .cc file, declaring and defining things
separately is a good idea, and keeps the declaration more readable.", and the
other notes about inline functions there also apply.

During my infobar rewrite I've found that major changes made to de-inlined class
definitions are generally easier to understand, since one can see API changes
and function-body changes separately.