Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 651353002: Move manifest_url_handler to //extensions (Closed)

Created:
6 years, 2 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 2 months ago
Reviewers:
scheib
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, nona+watch_chromium.org, dbeam+watch-options_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@download-manifest-url-handler
Project:
chromium
Visibility:
Public.

Description

Move manifest_url_handler to //extensions This moves extensions manifest URL handlers into //extensions and renames the source files more appropriately to "manifest_url_handlers" Mechanical change, so all this noise is only header updates. TBRs are for header changes only. BUG=398671 [email protected] for app_mode change [email protected] for themes change [email protected] for ui changes Committed: https://crrev.com/d5546141d24623e5653bbb1f1cc4aba831dcef0c Cr-Commit-Position: refs/heads/master@{#299598}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -338 lines) Patch
M chrome/browser/chromeos/app_mode/startup_app_launcher.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/management/management_api.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/module/module.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/streams_private/streams_private_manifest_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_assets_manager_chromeos.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_context_menu_model.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_sync_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_system_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/external_install_manager.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/install_verifier.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/installed_loader.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/updater/extension_downloader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/themes/theme_syncable_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/themes/theme_syncable_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_context_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_controller_delegate.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/extension_app_item.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_basic_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/chrome_manifest_handlers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/chrome_manifest_url_handlers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/ui_overrides_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_about_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_homepage_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_update_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/extensions/manifest_url_handler.h View 1 chunk +0 lines, -102 lines 0 comments Download
D chrome/common/extensions/manifest_url_handler.cc View 1 chunk +0 lines, -196 lines 0 comments Download
M chrome/common/extensions/sync_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + extensions/common/manifest_url_handlers.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/manifest_url_handlers.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Ken Rockot(use gerrit already)
Vince could you please take a look?
6 years, 2 months ago (2014-10-14 21:39:44 UTC) #2
scheib
lgtm
6 years, 2 months ago (2014-10-14 22:42:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/651353002/1
6 years, 2 months ago (2014-10-14 22:45:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/17627)
6 years, 2 months ago (2014-10-14 22:55:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/651353002/1
6 years, 2 months ago (2014-10-14 23:02:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-15 00:29:16 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 00:30:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d5546141d24623e5653bbb1f1cc4aba831dcef0c
Cr-Commit-Position: refs/heads/master@{#299598}

Powered by Google App Engine
This is Rietveld 408576698