Issue 6718020: Move some more renderer messages to content.

Issue 6718020: Move some more renderer messages to content. (Closed)

Created:
9 years, 9 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
Tom Sepez

CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, jam, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Move some more renderer messages to content. Also move a couple of files which should have been moved.TBR=tsepez [email protected],*,[email protected],[email protected],[email protected],[email protected],[email protected],[email protected] Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78957

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+237 lines, -781 lines)			Patch
chrome/browser/renderer_host/gtk_key_bindings_handler.h	View		1 chunk	+1 line, -1 line	0 comments	Download
chrome/browser/renderer_host/gtk_key_bindings_handler_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
chrome/browser/renderer_host/render_widget_host_view_mac.h	View		1 chunk	+1 line, -1 line	0 comments	Download
chrome/browser/renderer_host/render_widget_host_view_mac.mm	View		2 chunks	+1 line, -1 line	0 comments	Download
chrome/chrome_renderer.gypi	View		1 chunk	+0 lines, -2 lines	0 comments	Download
chrome/chrome_tests.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
chrome/common/edit_command.h	View		1 chunk	+0 lines, -25 lines	0 comments	Download
chrome/common/render_messages.h	View		12 chunks	+9 lines, -156 lines	0 comments	Download
chrome/common/render_messages.cc	View		4 chunks	+0 lines, -192 lines	0 comments	Download
chrome/common/render_messages_params.h	View		3 chunks	+0 lines, -35 lines	0 comments	Download
chrome/common/render_messages_params.cc	View		2 chunks	+0 lines, -49 lines	0 comments	Download
chrome/common/webkit_param_traits.h	View		2 chunks	+0 lines, -14 lines	0 comments	Download
chrome/common/webkit_param_traits.cc	View		2 chunks	+0 lines, -39 lines	0 comments	Download
chrome/renderer/blocked_plugin.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
chrome/renderer/external_popup_menu.h	View		1 chunk	+0 lines, -40 lines	0 comments	Download
chrome/renderer/external_popup_menu.cc	View		1 chunk	+0 lines, -47 lines	0 comments	Download
chrome/renderer/external_popup_menu_unittest.cc	View		1 chunk	+0 lines, -141 lines	0 comments	Download
chrome/renderer/mock_render_thread.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
chrome/renderer/page_click_tracker.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
chrome/test/render_view_test.cc	View	1 2	2 chunks	+1 line, -1 line	0 comments	Download
content/browser/renderer_host/render_view_host.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
content/browser/renderer_host/render_view_host.cc	View		2 chunks	+2 lines, -11 lines	0 comments	Download
content/browser/renderer_host/render_widget_host.h	View		1 chunk	+1 line, -1 line	0 comments	Download
content/browser/renderer_host/render_widget_host_unittest.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
content/common/edit_command.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
content/common/view_messages.h	View		5 chunks	+198 lines, -1 line	0 comments	Download
content/content_common.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
content/content_renderer.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
content/renderer/external_popup_menu.h	View		2 chunks	+3 lines, -4 lines	0 comments	Download
content/renderer/external_popup_menu.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
content/renderer/external_popup_menu_unittest.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
content/renderer/pepper_plugin_delegate_impl.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
content/renderer/render_view.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
content/renderer/render_view.cc	View		3 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Tom Sepez

Weird. The links in the latest patch set are broken right now. The links in ...

9 years, 9 months ago (2011-03-22 16:30:58 UTC) #2

jam

9 years, 9 months ago (2011-03-22 16:52:15 UTC) #3

On Tue, Mar 22, 2011 at 9:30 AM, <[email protected]> wrote:

> Weird. The links in the latest patch set are broken right now.   The links
> in
> Patch set #2 are Ok.

must have been a bad upload (i.e. app engine throws 500's while uploading)

>  Looking at #2, did you intend to remove CaptureThumbnail()
> from render_view_host.h ?

yep, it's not being used anymore.

>
>
> http://codereview.chromium.org/6718020/
>

Expand Messages | Collapse Messages