Standardize usage of virtual/override/final specifiers.

Standardize usage of virtual/override/final specifiers.

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
[email protected]

Committed: https://crrev.com/1f4538e02ae35659abf7f9468639a1045924af50
Cr-Commit-Position: refs/heads/master@{#301490}

[Daniel Erat, 2014-10-27 21:55:49]

lgtm

https://codereview.chromium.org/680153002/diff/1/ash/first_run/desktop_cleane...
File ash/first_run/desktop_cleaner.cc (right):

https://codereview.chromium.org/680153002/diff/1/ash/first_run/desktop_cleane...
ash/first_run/desktop_cleaner.cc:82: ~NotificationBlocker() override{};
i feel like the following, with a space between 'override' and '{' and no
trailing semicolon, is more common both in chrome and even just within this
change:

  ~NotificationBlocker() override {}

https://codereview.chromium.org/680153002/diff/1/ash/root_window_controller_u...
File ash/root_window_controller_unittest.cc (right):

https://codereview.chromium.org/680153002/diff/1/ash/root_window_controller_u...
ash/root_window_controller_unittest.cc:612:
~VirtualKeyboardRootWindowControllerTest() override{};
nit: override {}

[dcheng, 2014-10-27 22:03:42]

https://codereview.chromium.org/680153002/diff/1/ash/first_run/desktop_cleane...
File ash/first_run/desktop_cleaner.cc (right):

https://codereview.chromium.org/680153002/diff/1/ash/first_run/desktop_cleane...
ash/first_run/desktop_cleaner.cc:82: ~NotificationBlocker() override{};
On 2014/10/27 21:55:49, Daniel Erat wrote:
> i feel like the following, with a space between 'override' and '{' and no
> trailing semicolon, is more common both in chrome and even just within this
> change:
> 
>   ~NotificationBlocker() override {}

I think this is a misformatting by clang-format. Thanks for catching this. I bet
the semicolon confuses it...

https://codereview.chromium.org/680153002/diff/1/ash/root_window_controller_u...
File ash/root_window_controller_unittest.cc (right):

https://codereview.chromium.org/680153002/diff/1/ash/root_window_controller_u...
ash/root_window_controller_unittest.cc:612:
~VirtualKeyboardRootWindowControllerTest() override{};
On 2014/10/27 21:55:49, Daniel Erat wrote:
> nit: override {}

Fixed this one too.

[dcheng, 2014-10-27 22:03:51]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2014-10-27 22:06:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/680153002/20001

[commit-bot: I haz the power, 2014-10-27 23:57:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-27 23:58:35]

Patchset 2 (id:??) landed as
https://crrev.com/1f4538e02ae35659abf7f9468639a1045924af50
Cr-Commit-Position: refs/heads/master@{#301490}