Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 6869051: Move PepperPluginRegistry to content, while leaving the Chrome specific bits (NaCl, registration ... (Closed)

Created:
9 years, 8 months ago by jam
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, Erik does not do reviews, Aaron Boodman, darin-cc_chromium.org
Visibility:
Public.

Description

Move PepperPluginRegistry to content, while leaving the Chrome specific bits (NaCl, registration of Chrome plugins like pdf/remoting/flash) behind. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81959

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+299 lines, -847 lines) Patch
M chrome/browser/extensions/extension_service.h View 1 2 3 3 chunks +26 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 3 8 chunks +64 lines, -6 lines 0 comments Download
M chrome/browser/pdf_unsupported_feature.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/plugin_updater.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/plugins_ui.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_content_client.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/chrome_content_client.cc View 1 2 3 2 chunks +168 lines, -0 lines 0 comments Download
D chrome/common/pepper_plugin_registry.h View 1 2 3 1 chunk +0 lines, -151 lines 0 comments Download
D chrome/common/pepper_plugin_registry.cc View 1 2 3 1 chunk +0 lines, -433 lines 0 comments Download
M chrome/renderer/renderer_main.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_service.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M content/browser/ppapi_broker_process_host.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/zygote_main_linux.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/common/content_client.h View 1 2 3 2 chunks +7 lines, -2 lines 0 comments Download
A + content/common/pepper_plugin_registry.h View 1 2 7 chunks +6 lines, -32 lines 0 comments Download
A + content/common/pepper_plugin_registry.cc View 1 2 5 chunks +8 lines, -208 lines 0 comments Download
M content/content_common.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/pepper_plugin_delegate_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
9 years, 8 months ago (2011-04-18 02:00:02 UTC) #1
brettw
LGTM, I'm excited most of that flash/nacl stuff could be moved out. http://codereview.chromium.org/6869051/diff/5003/chrome/common/chrome_content_client.cc File chrome/common/chrome_content_client.cc ...
9 years, 8 months ago (2011-04-18 05:02:12 UTC) #2
brettw
Can you double-check that you used "svn mv" on the pepper_plugin_registry.* files? It doesn't show ...
9 years, 8 months ago (2011-04-18 14:56:19 UTC) #3
jam
9 years, 8 months ago (2011-04-18 15:51:59 UTC) #4
good catch, I had moved it in the original checkout that i did this change
in, but then moved this small part to another checkout and forgot to there.
 fixed

On Mon, Apr 18, 2011 at 7:56 AM, <[email protected]> wrote:

> Can you double-check that you used "svn mv" on the pepper_plugin_registry.*
> files? It doesn't show up in this diff.
>
>
> http://codereview.chromium.org/6869051/
>

Powered by Google App Engine
This is Rietveld 408576698