Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 7604023: Deploy win flapper via component updater (Closed)

Created:
9 years, 4 months ago by cpu_(ooo_6.6-7.5)
Modified:
9 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Deploy win flapper via component updater - Flapper specific installer - a small bug fix on the updater_configurator - wired into chrome startup in browser_init - changes to chrome_paths to override flapper path TEST=see bug BUG=89248 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96247

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 6

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -44 lines) Patch
M chrome/browser/component_updater/component_updater_configurator.cc View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/component_updater/pepper_flash_component_installer.h View 1 chunk +17 lines, -0 lines 0 comments Download
A chrome/browser/component_updater/pepper_flash_component_installer.cc View 1 2 3 1 chunk +181 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_init.cc View 3 chunks +16 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_paths.cc View 3 chunks +0 lines, -42 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
cpu_(ooo_6.6-7.5)
9 years, 4 months ago (2011-08-10 03:56:07 UTC) #1
brettw
http://codereview.chromium.org/7604023/diff/8/chrome/browser/component_updater/pepper_flash_component_installer.cc File chrome/browser/component_updater/pepper_flash_component_installer.cc (right): http://codereview.chromium.org/7604023/diff/8/chrome/browser/component_updater/pepper_flash_component_installer.cc#newcode18 chrome/browser/component_updater/pepper_flash_component_installer.cc:18: namespace { Blank line after this. http://codereview.chromium.org/7604023/diff/8/chrome/browser/component_updater/pepper_flash_component_installer.cc#newcode54 chrome/browser/component_updater/pepper_flash_component_installer.cc:54: PathService::Get(base::DIR_EXE, ...
9 years, 4 months ago (2011-08-10 06:04:06 UTC) #2
cpu_(ooo_6.6-7.5)
all fixed. please check again. http://codereview.chromium.org/7604023/diff/8/chrome/browser/component_updater/pepper_flash_component_installer.cc File chrome/browser/component_updater/pepper_flash_component_installer.cc (right): http://codereview.chromium.org/7604023/diff/8/chrome/browser/component_updater/pepper_flash_component_installer.cc#newcode18 chrome/browser/component_updater/pepper_flash_component_installer.cc:18: namespace { On 2011/08/10 ...
9 years, 4 months ago (2011-08-10 20:08:30 UTC) #3
brettw
9 years, 4 months ago (2011-08-10 20:11:53 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698