Issue 7669026: Rename ConstrainedHtmlDelegateWin to ConstrainedHtmlDelegateViews.

Issue 7669026: Rename ConstrainedHtmlDelegateWin to ConstrainedHtmlDelegateViews. (Closed)

Created:
9 years, 4 months ago by rhashimoto

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Rename ConstrainedHtmlDelegateWin to ConstrainedHtmlDelegateViews. This file does not contain Windows-specific code and will be used for WebUI constrained windows on ChromiumOS. BUG=chromium-os:13900 TEST=windows still builds Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97317

Patch Set 2 : Implement reviewer recommendation. #

Patch Set 3 : Rebase to trunk. #

Patch Set 4 : Rebase to trunk again. #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -131 lines)			Patch
A +	chrome/browser/ui/views/constrained_html_delegate_views.cc	View	1	6 chunks	+18 lines, -13 lines	0 comments	Download
D	chrome/browser/ui/views/constrained_html_delegate_win.cc	View		1 chunk	+0 lines, -117 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

LGTM 1 nit: http://codereview.chromium.org/7669026/diff/1/chrome/browser/ui/views/constrained_html_delegate_views.cc File chrome/browser/ui/views/constrained_html_delegate_views.cc (right): http://codereview.chromium.org/7669026/diff/1/chrome/browser/ui/views/constrained_html_delegate_views.cc#newcode47 chrome/browser/ui/views/constrained_html_delegate_views.cc:47: { brace to prev line

9 years, 4 months ago (2011-08-17 21:36:36 UTC) #2

rhashimoto

http://codereview.chromium.org/7669026/diff/1/chrome/browser/ui/views/constrained_html_delegate_views.cc File chrome/browser/ui/views/constrained_html_delegate_views.cc (right): http://codereview.chromium.org/7669026/diff/1/chrome/browser/ui/views/constrained_html_delegate_views.cc#newcode47 chrome/browser/ui/views/constrained_html_delegate_views.cc:47: { On 2011/08/17 21:36:36, Ben Goodger (Google) wrote: > ...

9 years, 4 months ago (2011-08-17 21:40:17 UTC) #3

commit-bot: I haz the power

Can't process patch for file chrome/browser/ui/views/constrained_html_delegate_views.cc. A +

9 years, 4 months ago (2011-08-18 15:44:01 UTC) #4

commit-bot: I haz the power

9 years, 4 months ago (2011-08-18 15:48:55 UTC) #5

Can't process patch for file
chrome/browser/ui/views/constrained_html_delegate_views.cc.
A +

Expand Messages | Collapse Messages