Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 7863017: Innocent rename of pepper_flash_component_installer.h (Closed)

Created:
9 years, 3 months ago by cpu_(ooo_6.6-7.5)
Modified:
9 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Innocent rename of pepper_flash_component_installer.h BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100558

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -23 lines) Patch
A + chrome/browser/component_updater/flash_component_installer.h View 2 chunks +3 lines, -3 lines 0 comments Download
D chrome/browser/component_updater/pepper_flash_component_installer.h View 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_init.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
cpu_(ooo_6.6-7.5)
I am TBRing this since is a simple file rename.
9 years, 3 months ago (2011-09-10 01:08:30 UTC) #1
brettw
9 years, 3 months ago (2011-09-10 02:34:27 UTC) #2
LGTM

On Fri, Sep 9, 2011 at 6:08 PM,  <[email protected]> wrote:
> Reviewers: brettw,
>
> Message:
> I am TBRing this since is a simple file rename.
>
>
> Description:
> Innocent rename of pepper_flash_component_installer.h
>
> BUG=none
> TEST=none
>
> Please review this at http://codereview.chromium.org/7863017/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  A  +  chrome/browser/component_updater/flash_component_installer.h
>  D     chrome/browser/component_updater/pepper_flash_component_installer.h
>  M     chrome/browser/component_updater/pepper_flash_component_installer.cc
>  M     chrome/browser/ui/browser_init.cc
>  M     chrome/chrome_browser.gypi
>
>
> ### BEGIN SVN COPY METADATA
> #$ cp
> trunk/src/chrome/browser/component_updater/pepper_flash_component_installer.h
> chrome\browser\component_updater\flash_component_installer.h
> ### END SVN COPY METADATA
> Index: chrome/browser/component_updater/flash_component_installer.h
> ===================================================================
> --- chrome/browser/component_updater/flash_component_installer.h
>  (revision 99785)
> +++ chrome/browser/component_updater/flash_component_installer.h
>  (working copy)
> @@ -2,8 +2,8 @@
>  // Use of this source code is governed by a BSD-style license that can be
>  // found in the LICENSE file.
>
> -#ifndef
> CHROME_BROWSER_COMPONENT_UPDATER_PEPPER_FLASH_COMPONENT_INSTALLER_H_
> -#define
> CHROME_BROWSER_COMPONENT_UPDATER_PEPPER_FLASH_COMPONENT_INSTALLER_H_
> +#ifndef CHROME_BROWSER_COMPONENT_UPDATER_FLASH_COMPONENT_INSTALLER_H_
> +#define CHROME_BROWSER_COMPONENT_UPDATER_FLASH_COMPONENT_INSTALLER_H_
>  #pragma once
>
>  class ComponentUpdateService;
> @@ -14,4 +14,4 @@
>  // The first part is IO intensive so we do it asynchronously in the file
> thread.
>  void RegisterPepperFlashComponent(ComponentUpdateService* cus);
>
> -#endif  //
> CHROME_BROWSER_COMPONENT_UPDATER_PEPPER_FLASH_COMPONENT_INSTALLER_H_
> +#endif  // CHROME_BROWSER_COMPONENT_UPDATER_FLASH_COMPONENT_INSTALLER_H_
> Index: chrome/browser/component_updater/pepper_flash_component_installer.cc
> ===================================================================
> --- chrome/browser/component_updater/pepper_flash_component_installer.cc
>    (revision 100504)
> +++ chrome/browser/component_updater/pepper_flash_component_installer.cc
>    (working copy)
> @@ -2,7 +2,7 @@
>  // Use of this source code is governed by a BSD-style license that can be
>  // found in the LICENSE file.
>
> -#include
> "chrome/browser/component_updater/pepper_flash_component_installer.h"
> +#include "chrome/browser/component_updater/flash_component_installer.h"
>
>  #include "base/base_paths.h"
>  #include "base/compiler_specific.h"
> Index: chrome/browser/component_updater/pepper_flash_component_installer.h
> ===================================================================
> --- chrome/browser/component_updater/pepper_flash_component_installer.h
> (revision 100504)
> +++ chrome/browser/component_updater/pepper_flash_component_installer.h
> (working copy)
> @@ -1,17 +0,0 @@
> -// Copyright (c) 2011 The Chromium Authors. All rights reserved.
> -// Use of this source code is governed by a BSD-style license that can be
> -// found in the LICENSE file.
> -
> -#ifndef
> CHROME_BROWSER_COMPONENT_UPDATER_PEPPER_FLASH_COMPONENT_INSTALLER_H_
> -#define
> CHROME_BROWSER_COMPONENT_UPDATER_PEPPER_FLASH_COMPONENT_INSTALLER_H_
> -#pragma once
> -
> -class ComponentUpdateService;
> -class FilePath;
> -
> -// Our job is to 1) find what pepper flash is installed (if any) and 2)
> register
> -// with the component updater to download the latest version when
> available.
> -// The first part is IO intensive so we do it asynchronously in the file
> thread.
> -void RegisterPepperFlashComponent(ComponentUpdateService* cus);
> -
> -#endif  //
> CHROME_BROWSER_COMPONENT_UPDATER_PEPPER_FLASH_COMPONENT_INSTALLER_H_
> Index: chrome/browser/ui/browser_init.cc
> ===================================================================
> --- chrome/browser/ui/browser_init.cc   (revision 100504)
> +++ chrome/browser/ui/browser_init.cc   (working copy)
> @@ -23,7 +23,7 @@
>  #include "chrome/browser/automation/testing_automation_provider.h"
>  #include "chrome/browser/browser_process.h"
>  #include "chrome/browser/component_updater/component_updater_service.h"
> -#include
> "chrome/browser/component_updater/pepper_flash_component_installer.h"
> +#include "chrome/browser/component_updater/flash_component_installer.h"
>  #include "chrome/browser/custom_handlers/protocol_handler_registry.h"
>  #include "chrome/browser/defaults.h"
>  #include "chrome/browser/extensions/extension_creator.h"
> Index: chrome/chrome_browser.gypi
> ===================================================================
> --- chrome/chrome_browser.gypi  (revision 100504)
> +++ chrome/chrome_browser.gypi  (working copy)
> @@ -798,8 +798,8 @@
>         'browser/component_updater/component_unpacker.h',
>         'browser/component_updater/component_updater_service.cc',
>         'browser/component_updater/component_updater_service.h',
> +        'browser/component_updater/flash_component_installer.h',
>         'browser/component_updater/pepper_flash_component_installer.cc',
> -        'browser/component_updater/pepper_flash_component_installer.h',
>         'browser/content_settings/content_settings_details.cc',
>         'browser/content_settings/content_settings_details.h',
>         'browser/content_settings/content_settings_extension_provider.cc',
>
>
>

Powered by Google App Engine
This is Rietveld 408576698