Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 788163002: Enable presubmit check for copyrighted material in added / modified code (Closed)

Created:
6 years ago by mnaganov (inactive)
Modified:
6 years ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enable presubmit check for copyrighted material in added / modified code This check is already for a long time performed on some of the main waterfall bots, including "Android Builder (dbg)", "Android Clang Builder (dbg)", "Android Arm64 Builder (dbg)", and also on trybots. The step is called "check licenses". However, it's better to detect issues even earlier, so we did make sure that the check can run on Windows, and would like to start running it during presubmit. Note that the presubmit check is simpler than the bot check, as it only scans the files for "copyright-like" strings, while the bot check also verifies that third-party projects contain Android-compatible licenses. BUG=343104 Committed: https://crrev.com/9b9b1fe81d32f77d3f364ab9a0a0a0cd5d97e829 Cr-Commit-Position: refs/heads/master@{#307908}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M PRESUBMIT.py View 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mnaganov (inactive)
Hi Pawel, Please take a look at the change -- it just flips the switch ...
6 years ago (2014-12-11 12:47:27 UTC) #2
Paweł Hajdan Jr.
LGTM
6 years ago (2014-12-11 14:39:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788163002/1
6 years ago (2014-12-11 15:34:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-11 16:30:44 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-11 16:32:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b9b1fe81d32f77d3f364ab9a0a0a0cd5d97e829
Cr-Commit-Position: refs/heads/master@{#307908}

Powered by Google App Engine
This is Rietveld 408576698