Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 78963002: VariationsService: Log reason why requests aren't allowed. (Closed)

Created:
7 years, 1 month ago by Alexei Svitkine (slow)
Modified:
7 years, 1 month ago
Reviewers:
jwd
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

VariationsService: Log reason why requests aren't allowed. Extends existing Variations.ResourceRequestsAllowed histogram to log the reason why requests weren't allowed. BUG=321677 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236443

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -18 lines) Patch
M chrome/browser/metrics/variations/variations_service.cc View 4 chunks +26 lines, -3 lines 0 comments Download
M chrome/browser/web_resource/resource_request_allowed_notifier.h View 2 chunks +18 lines, -5 lines 0 comments Download
M chrome/browser/web_resource/resource_request_allowed_notifier.cc View 2 chunks +11 lines, -3 lines 0 comments Download
M chrome/browser/web_resource/resource_request_allowed_notifier_test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_resource/resource_request_allowed_notifier_test_util.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Alexei Svitkine (slow)
7 years, 1 month ago (2013-11-20 17:57:05 UTC) #1
Alexei Svitkine (slow)
Fixed compile error. PTAL.
7 years, 1 month ago (2013-11-20 19:56:46 UTC) #2
jwd
lgtm
7 years, 1 month ago (2013-11-20 21:06:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/78963002/60002
7 years, 1 month ago (2013-11-20 21:24:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/78963002/60002
7 years, 1 month ago (2013-11-21 02:10:41 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-21 07:38:07 UTC) #6
Message was sent while issue was closed.
Change committed as 236443

Powered by Google App Engine
This is Rietveld 408576698