Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 7980012: [ChromeOS] Reland - Make WebUI login use only needed resources. (Closed)

Created:
9 years, 3 months ago by xiyuan
Modified:
9 years, 3 months ago
Reviewers:
CC:
chromium-reviews, davemoore+watch_chromium.org, stevenjb, arv (Not doing code reviews), nkostylev+cc_chromium.org, rharrison
Visibility:
Public.

Description

[ChromeOS] Reland - Make WebUI login use only needed resources. So that we speed up a bit in boot. For OOBE, use chrome://oobe that has everything. For login case, use chrome://oobe/login which only loads account picker, gaia, user image select and offline message. - Create login.html etc based on oobe.html etc with OOBE only stuff removed; - Move core OOBE js logic into DisplayManager so that it could be shared; - Move header bar stuff into its own files; - Removed non Gaia signin since it seems no longer needed; - Also removed login_ui files since they are no longer in use; BUG=chromium-os:20187 TEST=We should speed up about 200ms in boot, resulting in about 380ms delay after this change. [email protected] Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102077

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+755 lines, -2362 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/webui_login_display_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/bubble.js View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/resources/chromeos/login/display_manager.js View 1 chunk +386 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/login/header_bar.css View 1 chunk +53 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/login/header_bar.html View 1 chunk +7 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/login/header_bar.js View 1 chunk +45 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/login/login.html View 1 chunk +67 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/login/login.js View 1 chunk +162 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe.css View 1 chunk +1 line, -47 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe.html View 5 chunks +6 lines, -14 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe.js View 8 chunks +10 lines, -343 lines 0 comments Download
A + chrome/browser/resources/chromeos/login/screen_gaia_signin.css View 2 chunks +0 lines, -13 lines 0 comments Download
D chrome/browser/resources/chromeos/login/screen_signin.css View 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/resources/chromeos/login/screen_signin.html View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/browser/resources/chromeos/login/screen_signin.js View 1 chunk +0 lines, -163 lines 0 comments Download
A chrome/browser/resources/chromeos/login/version.html View 1 chunk +4 lines, -0 lines 0 comments Download
D chrome/browser/resources/common_oobe_login.css View 1 chunk +0 lines, -231 lines 0 comments Download
D chrome/browser/resources/login.css View 1 chunk +0 lines, -135 lines 0 comments Download
D chrome/browser/resources/login.html View 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/resources/login.js View 1 chunk +0 lines, -679 lines 0 comments Download
D chrome/browser/resources/login_ui.css View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/resources/slider.js View 1 chunk +0 lines, -247 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_factory.cc View 2 chunks +0 lines, -3 lines 0 comments Download
D chrome/browser/ui/webui/chromeos/login/login_ui.h View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/ui/webui/chromeos/login/login_ui.cc View 1 chunk +0 lines, -93 lines 0 comments Download
D chrome/browser/ui/webui/chromeos/login/login_ui_helpers.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/ui/webui/chromeos/login/login_ui_helpers.cc View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/ui/webui/chromeos/login/mock_login_ui_handler.h View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/ui/webui/chromeos/login/mock_login_ui_helpers.h View 1 chunk +0 lines, -57 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -4 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698