Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 830002: win: string_util.h -> utf_string_conversions.h fix. (Closed)

Created:
10 years, 9 months ago by James Hawkins
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, fbarchard, Alpha Left Google, ben+cc_chromium.org, Erik does not do reviews, Paul Godavari, jam, Aaron Boodman, dpranke+watch_chromium.org, darin-cc_chromium.org, awong, Paweł Hajdan Jr., kuchhal, pam+watch_chromium.org, amit, scherkus (not reviewing)
Visibility:
Public.

Description

win: string_util.h -> utf_string_conversions.h fix. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41292

Patch Set 1 #

Patch Set 2 : Don't remove utf_string_conversions.h from string_util.h just yet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -50 lines) Patch
M app/clipboard/clipboard_util_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M app/clipboard/clipboard_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M app/l10n_util_dummy.cc View 1 chunk +1 line, -1 line 0 comments Download
M app/os_exchange_data_provider_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M app/os_exchange_data_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M app/sql/connection.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/string_util.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/fileicon_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_file.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/in_memory_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/url_fixer_upper_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/parsers/metadata_parser_filebase.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/parsers/metadata_parser_jpeg_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/about_network_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/appcache_info_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/bug_report_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/cookie_prompt_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/database_info_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/database_open_info_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/external_protocol_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/local_storage_info_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/local_storage_set_item_info_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/notifications/balloon_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/options/exception_editor_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/page_info_window_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/shell_dialogs_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/tabs/side_tab.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/url_picker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/web_database_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/child_process_logging_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/extension_file_util_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/zip.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/installer/util/lzma_util.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/mini_installer_test/mini_installer_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/profiles/generate_profile.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/com_message_event.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome_frame/np_event_listener.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome_frame/test/chrome_frame_test_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/filters/file_data_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/file_data_source_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/tools/player_wtl/movie.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/mime_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/net_util_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/platform_mime_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/x509_certificate_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/socket/ssl_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/label.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/label_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/message_box_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/drag_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/examples/menu_example.h View 1 chunk +1 line, -0 lines 0 comments Download
M views/examples/textfield_example.h View 1 chunk +1 line, -1 line 0 comments Download
M views/view.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/default_plugin/plugin_database_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/plugins/plugin_stream.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_webview_delegate_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
James Hawkins
10 years, 9 months ago (2010-03-10 22:34:12 UTC) #1
brettw
10 years, 9 months ago (2010-03-11 04:39:04 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698