Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Issue 8333004: Rename InterfaceID to ApiID and move the file. (Closed)

Created:
9 years, 2 months ago by brettw
Modified:
9 years, 2 months ago
Reviewers:
bbudge
CC:
chromium-reviews, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Rename InterfaceID to ApiID and move the file. This was originally in the proxy and had a 1:1 correspondence with an interface. Then we reused this for other stuff and then merged some interfaces into larger APIs (ppapi/thunk/*_api.h) so the name was no longer accurate. It was wrong to be in the proxy directory since directories at a "lower level" than the proxy (ppapi/shared_impl and webkit/plugins/ppapi) depended on it. This renames to ApiID (I avoided APIID since it looks like a define) which is the proper description of the class, and moved it to shared_impl. This fixes the deps since there are no longer any bad dependencies on the proxy directory. TEST=it compiles BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106619

Patch Set 1 #

Patch Set 2 : Tests fixed #

Patch Set 3 : Merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+381 lines, -392 lines) Patch
M ppapi/proxy/dispatcher.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/dispatcher.cc View 2 chunks +3 lines, -3 lines 0 comments Download
D ppapi/proxy/interface_id.h View 1 chunk +0 lines, -69 lines 0 comments Download
M ppapi/proxy/interface_list.h View 3 chunks +11 lines, -11 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 7 chunks +23 lines, -23 lines 0 comments Download
M ppapi/proxy/interface_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/plugin_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/plugin_dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/plugin_dispatcher_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/proxy/plugin_globals.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/plugin_globals.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ppapi/proxy/plugin_resource_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/plugin_var_tracker.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_audio_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_audio_proxy.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_broker_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_broker_proxy.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_buffer_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_buffer_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_context_3d_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_context_3d_proxy.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M ppapi/proxy/ppb_core_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_cursor_control_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_cursor_control_proxy.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_file_chooser_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_file_chooser_proxy.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_file_ref_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_file_ref_proxy.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M ppapi/proxy/ppb_file_system_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_file_system_proxy.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_flash_clipboard_proxy.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_flash_file_proxy.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M ppapi/proxy/ppb_flash_menu_proxy.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_flash_net_connector_proxy.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M ppapi/proxy/ppb_flash_proxy.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M ppapi/proxy/ppb_flash_tcp_socket_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_flash_udp_socket_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_font_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_graphics_2d_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_graphics_2d_proxy.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M ppapi/proxy/ppb_graphics_3d_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_graphics_3d_proxy.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_instance_proxy.cc View 1 2 20 chunks +24 lines, -24 lines 0 comments Download
M ppapi/proxy/ppb_pdf_proxy.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_surface_3d_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_surface_3d_proxy.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_testing_proxy.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_text_input_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_text_input_proxy.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_url_loader_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_url_loader_proxy.cc View 8 chunks +11 lines, -11 lines 0 comments Download
M ppapi/proxy/ppb_url_response_info_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_url_response_info_proxy.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_var_deprecated_proxy.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M ppapi/proxy/ppb_video_capture_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_video_capture_proxy.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M ppapi/proxy/ppb_video_decoder_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_video_decoder_proxy.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M ppapi/proxy/ppp_class_proxy.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M ppapi/proxy/ppp_graphics_3d_proxy.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ppapi/proxy/ppp_input_event_proxy.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/ppp_instance_private_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppp_instance_proxy.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M ppapi/proxy/ppp_messaging_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppp_mouse_lock_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppp_video_decoder_proxy.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ppapi/shared_impl/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A ppapi/shared_impl/api_id.h View 1 chunk +67 lines, -0 lines 0 comments Download
M ppapi/shared_impl/ppapi_globals.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/shared_impl/test_globals.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/test_globals.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M ppapi/shared_impl/video_decoder_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
A ppapi/thunk/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
M ppapi/thunk/enter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/thunk/ppb_cursor_control_api.h View 2 chunks +2 lines, -3 lines 0 comments Download
M ppapi/thunk/ppb_font_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/thunk/ppb_instance_api.h View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M ppapi/thunk/ppb_text_input_api.h View 2 chunks +2 lines, -3 lines 0 comments Download
M ppapi/thunk/resource_creation_api.h View 2 chunks +2 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/plugins/ppapi/host_globals.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/host_globals.cc View 5 chunks +9 lines, -10 lines 0 comments Download
M webkit/plugins/ppapi/host_var_tracker.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
Lots of files but this is a mechanical search-and-replace for the most part. Might be ...
9 years, 2 months ago (2011-10-17 23:52:15 UTC) #1
bbudge
9 years, 2 months ago (2011-10-18 00:15:25 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698