Revert 108206 - Share TabFirstRenderWatcher with HtmlDialogView.

Revert 108206 - Share TabFirstRenderWatcher with HtmlDialogView.

- Move TabFirstRenderWatcher out of chromeos and combine the logic with HTMLDialgoView.
- Update HtmlDialogBrowserTest.TestStateTransition and move state transition test into TabFirstRenderWatcherTest.TestStateTransition;
- HtmlDialogBrowserTest.TestStateTransition -> WebContentRendered as it only tests OnTabMainFrameFirstRender is callled now;
- Conslidate two TestHtmlDialogUIDelegate into one;

Will share it with the auro app list window to avoid initial jankiness.

BUG=98308, 86059
TEST=Hold until all app list changes are in.


Review URL: http://codereview.chromium.org/8417005

[email protected]
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108276

[glotov, 2011-11-02 14:44:41]

Hi! Sorry for false revert of your change. I reverted my revert @108288.

On Wed, Nov 2, 2011 at 4:56 PM,  <[email protected]> wrote:
> Reviewers: xiyuan,
>
> Description:
> Revert 108206 - Share TabFirstRenderWatcher with HtmlDialogView.
>
> - Move TabFirstRenderWatcher out of chromeos and combine the logic with
> HTMLDialgoView.
> - Update HtmlDialogBrowserTest.TestStateTransition and move state transition
> test into TabFirstRenderWatcherTest.TestStateTransition;
> - HtmlDialogBrowserTest.TestStateTransition -> WebContentRendered as it only
> tests OnTabMainFrameFirstRender is callled now;
> - Conslidate two TestHtmlDialogUIDelegate into one;
>
> Will share it with the auro app list window to avoid initial jankiness.
>
> BUG=98308,86059
> TEST=Hold until all app list changes are in.
>
>
> Review URL: http://codereview.chromium.org/8417005
>
> [email protected]
>
> Please review this at http://codereview.chromium.org/8351070/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/chromeos/login/webui_login_view.h
>  A  +  chrome/browser/chromeos/tab_first_render_watcher.h
>  A  +  chrome/browser/chromeos/tab_first_render_watcher.cc
>  D     chrome/browser/tab_first_render_watcher.h
>  D     chrome/browser/tab_first_render_watcher.cc
>  D     chrome/browser/tab_first_render_watcher_browsertest.cc
>  M     chrome/browser/ui/views/html_dialog_view.h
>  M     chrome/browser/ui/views/html_dialog_view.cc
>  M     chrome/browser/ui/views/html_dialog_view_browsertest.cc
>  M     chrome/browser/ui/webui/constrained_html_ui_browsertest.cc
>  D     chrome/browser/ui/webui/test_html_dialog_ui_delegate.h
>  D     chrome/browser/ui/webui/test_html_dialog_ui_delegate.cc
>  M     chrome/chrome_browser.gypi
>  M     chrome/chrome_tests.gypi
>
>
>



-- 
Thank you,
Denis