Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 842993002: Update {virtual,override,final} for base to follow C++11 style. (Closed)

Created:
5 years, 11 months ago by dcheng
Modified:
5 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} for base to follow C++11 style. This patch was automatically generated using a variation of https://codereview.chromium.org/598073004 BUG=417463 Committed: https://crrev.com/769b4bf3c99510a8e9ff47f4fd1f6f1054097eb2 Cr-Commit-Position: refs/heads/master@{#310660}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M base/mac/libdispatch_task_runner_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/mac/scoped_sending_event_unittest.mm View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
5 years, 11 months ago (2015-01-08 23:37:31 UTC) #2
Nico
lgtm This lgtm was generated automatically by the equivalent of a very short shell script.
5 years, 11 months ago (2015-01-08 23:39:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/842993002/1
5 years, 11 months ago (2015-01-08 23:44:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 01:47:58 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 01:50:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/769b4bf3c99510a8e9ff47f4fd1f6f1054097eb2
Cr-Commit-Position: refs/heads/master@{#310660}

Powered by Google App Engine
This is Rietveld 408576698