Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 8473009: base::Bind() conversion for IOThread. (Closed)

Created:
9 years, 1 month ago by dcheng
Modified:
9 years, 1 month ago
Reviewers:
James Hawkins
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M chrome/browser/io_thread.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/io_thread.cc View 1 6 chunks +11 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dcheng
9 years, 1 month ago (2011-11-20 18:54:26 UTC) #1
James Hawkins
http://codereview.chromium.org/8473009/diff/1/chrome/browser/io_thread.cc File chrome/browser/io_thread.cc (right): http://codereview.chromium.org/8473009/diff/1/chrome/browser/io_thread.cc#newcode374 chrome/browser/io_thread.cc:374: MessageLoop::current()->PostTask(FROM_HERE, You could save a line by shifting this: ...
9 years, 1 month ago (2011-11-20 20:23:55 UTC) #2
dcheng
http://codereview.chromium.org/8473009/diff/1/chrome/browser/io_thread.cc File chrome/browser/io_thread.cc (right): http://codereview.chromium.org/8473009/diff/1/chrome/browser/io_thread.cc#newcode374 chrome/browser/io_thread.cc:374: MessageLoop::current()->PostTask(FROM_HERE, On 2011/11/20 20:23:55, James Hawkins wrote: > You ...
9 years, 1 month ago (2011-11-20 23:09:24 UTC) #3
James Hawkins
LGTM
9 years, 1 month ago (2011-11-20 23:26:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/8473009/4002
9 years, 1 month ago (2011-11-21 01:09:49 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-21 02:17:54 UTC) #6
Change committed as 110874

Powered by Google App Engine
This is Rietveld 408576698