Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 8790004: Rename the shared impl files. (Closed)

Created:
9 years ago by brettw
Modified:
9 years ago
Reviewers:
yzshen1
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Rename the shared_impl resource files to give them more regular names. I keep getting confused between things like AudioImpl and PPB_Audio_Impl. This uses _shared for the names, so now we have _impl, _proxy, and _shared which makes more sense. I also removed the ppb_opengles2_impl file since it was just a forward to the shared version. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113290

Patch Set 1 #

Patch Set 2 : New one #

Total comments: 1

Patch Set 3 : Merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+440 lines, -3601 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 4 chunks +6 lines, -5 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 1 2 chunks +31 lines, -32 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppapi_param_traits.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_audio_input_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_audio_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_file_ref_proxy.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_graphics_3d_proxy.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_image_data_proxy.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.cc View 1 4 chunks +10 lines, -7 lines 0 comments Download
M ppapi/proxy/ppb_testing_proxy.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_video_decoder_proxy.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_video_decoder_proxy.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppp_input_event_proxy.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.cc View 1 2 10 chunks +16 lines, -16 lines 0 comments Download
D ppapi/shared_impl/audio_config_impl.h View 1 chunk +0 lines, -52 lines 0 comments Download
D ppapi/shared_impl/audio_config_impl.cc View 1 chunk +0 lines, -76 lines 0 comments Download
D ppapi/shared_impl/audio_impl.h View 1 chunk +0 lines, -87 lines 0 comments Download
D ppapi/shared_impl/audio_impl.cc View 1 chunk +0 lines, -92 lines 0 comments Download
D ppapi/shared_impl/audio_input_impl.h View 1 chunk +0 lines, -88 lines 0 comments Download
D ppapi/shared_impl/audio_input_impl.cc View 1 chunk +0 lines, -94 lines 0 comments Download
D ppapi/shared_impl/char_set_impl.h View 1 chunk +0 lines, -33 lines 0 comments Download
D ppapi/shared_impl/char_set_impl.cc View 1 chunk +0 lines, -152 lines 0 comments Download
D ppapi/shared_impl/crypto_impl.cc View 1 chunk +0 lines, -36 lines 0 comments Download
D ppapi/shared_impl/file_ref_impl.h View 1 chunk +0 lines, -65 lines 0 comments Download
D ppapi/shared_impl/file_ref_impl.cc View 1 chunk +0 lines, -65 lines 0 comments Download
D ppapi/shared_impl/font_impl.h View 1 1 chunk +0 lines, -32 lines 0 comments Download
D ppapi/shared_impl/font_impl.cc View 1 1 chunk +0 lines, -34 lines 0 comments Download
D ppapi/shared_impl/graphics_3d_impl.h View 1 1 chunk +0 lines, -76 lines 0 comments Download
D ppapi/shared_impl/graphics_3d_impl.cc View 1 1 chunk +0 lines, -137 lines 0 comments Download
D ppapi/shared_impl/image_data_impl.h View 1 1 chunk +0 lines, -31 lines 0 comments Download
D ppapi/shared_impl/image_data_impl.cc View 1 1 chunk +0 lines, -27 lines 0 comments Download
D ppapi/shared_impl/input_event_impl.h View 1 1 chunk +0 lines, -100 lines 0 comments Download
D ppapi/shared_impl/input_event_impl.cc View 1 1 chunk +0 lines, -131 lines 0 comments Download
D ppapi/shared_impl/instance_impl.h View 1 1 chunk +0 lines, -24 lines 0 comments Download
D ppapi/shared_impl/instance_impl.cc View 1 1 chunk +0 lines, -30 lines 0 comments Download
D ppapi/shared_impl/memory_impl.cc View 1 1 chunk +0 lines, -43 lines 0 comments Download
D ppapi/shared_impl/opengles2_impl.h View 1 1 chunk +0 lines, -21 lines 0 comments Download
D ppapi/shared_impl/opengles2_impl.cc View 1 1 chunk +0 lines, -898 lines 0 comments Download
A + ppapi/shared_impl/ppb_audio_config_shared.h View 4 chunks +10 lines, -8 lines 0 comments Download
A + ppapi/shared_impl/ppb_audio_config_shared.cc View 1 chunk +21 lines, -17 lines 0 comments Download
A + ppapi/shared_impl/ppb_audio_input_shared.h View 3 chunks +9 lines, -6 lines 0 comments Download
A + ppapi/shared_impl/ppb_audio_input_shared.cc View 6 chunks +10 lines, -10 lines 0 comments Download
A + ppapi/shared_impl/ppb_audio_shared.h View 3 chunks +8 lines, -6 lines 0 comments Download
A + ppapi/shared_impl/ppb_audio_shared.cc View 6 chunks +13 lines, -11 lines 0 comments Download
A + ppapi/shared_impl/ppb_char_set_shared.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + ppapi/shared_impl/ppb_char_set_shared.cc View 3 chunks +13 lines, -11 lines 0 comments Download
A + ppapi/shared_impl/ppb_crypto_shared.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/ppb_file_ref_shared.h View 3 chunks +10 lines, -9 lines 0 comments Download
A + ppapi/shared_impl/ppb_file_ref_shared.cc View 5 chunks +11 lines, -9 lines 0 comments Download
A + ppapi/shared_impl/ppb_font_shared.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
A + ppapi/shared_impl/ppb_font_shared.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
A + ppapi/shared_impl/ppb_graphics_3d_shared.h View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
A + ppapi/shared_impl/ppb_graphics_3d_shared.cc View 1 5 chunks +22 lines, -22 lines 0 comments Download
A + ppapi/shared_impl/ppb_image_data_shared.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
A + ppapi/shared_impl/ppb_image_data_shared.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
A + ppapi/shared_impl/ppb_input_event_shared.h View 1 4 chunks +11 lines, -11 lines 0 comments Download
A + ppapi/shared_impl/ppb_input_event_shared.cc View 1 2 chunks +25 lines, -25 lines 0 comments Download
A + ppapi/shared_impl/ppb_instance_shared.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
A + ppapi/shared_impl/ppb_instance_shared.cc View 1 1 chunk +5 lines, -4 lines 0 comments Download
A + ppapi/shared_impl/ppb_memory_shared.cc View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/ppb_opengles2_shared.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + ppapi/shared_impl/ppb_opengles2_shared.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
A + ppapi/shared_impl/ppb_url_request_info_shared.h View 1 4 chunks +8 lines, -8 lines 0 comments Download
A + ppapi/shared_impl/ppb_url_request_info_shared.cc View 1 8 chunks +27 lines, -19 lines 0 comments Download
A + ppapi/shared_impl/ppb_url_util_shared.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
A + ppapi/shared_impl/ppb_url_util_shared.cc View 1 5 chunks +13 lines, -11 lines 0 comments Download
A + ppapi/shared_impl/ppb_video_decoder_shared.h View 1 3 chunks +7 lines, -7 lines 0 comments Download
A + ppapi/shared_impl/ppb_video_decoder_shared.cc View 1 6 chunks +12 lines, -12 lines 0 comments Download
D ppapi/shared_impl/url_request_info_impl.h View 1 1 chunk +0 lines, -136 lines 0 comments Download
D ppapi/shared_impl/url_request_info_impl.cc View 1 1 chunk +0 lines, -264 lines 0 comments Download
D ppapi/shared_impl/url_util_impl.h View 1 1 chunk +0 lines, -53 lines 0 comments Download
D ppapi/shared_impl/url_util_impl.cc View 1 1 chunk +0 lines, -113 lines 0 comments Download
D ppapi/shared_impl/video_decoder_impl.h View 1 1 chunk +0 lines, -77 lines 0 comments Download
D ppapi/shared_impl/video_decoder_impl.cc View 1 1 chunk +0 lines, -88 lines 0 comments Download
M ppapi/thunk/ppb_char_set_thunk.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_image_data_thunk.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/thunk/ppb_url_util_thunk.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 1 2 6 chunks +15 lines, -14 lines 0 comments Download
M webkit/plugins/ppapi/ppb_audio_impl.h View 2 chunks +5 lines, -5 lines 0 comments Download
M webkit/plugins/ppapi/ppb_audio_input_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppb_file_ref_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppb_file_ref_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppb_font_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppb_graphics_3d_impl.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppb_image_data_impl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
D webkit/plugins/ppapi/ppb_opengles_impl.h View 1 1 chunk +0 lines, -22 lines 0 comments Download
D webkit/plugins/ppapi/ppb_opengles_impl.cc View 1 1 chunk +0 lines, -18 lines 0 comments Download
M webkit/plugins/ppapi/ppb_url_loader_impl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_url_request_info_impl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppb_url_request_info_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_video_decoder_impl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppb_video_decoder_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/resource_creation_impl.cc View 1 6 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
Lots of files but this is just a mechanical rename
9 years ago (2011-12-02 23:48:11 UTC) #1
yzshen1
9 years ago (2011-12-03 00:29:04 UTC) #2
LGTM

Thanks!

http://codereview.chromium.org/8790004/diff/2001/ppapi/shared_impl/ppb_graphi...
File ppapi/shared_impl/ppb_graphics_3d_shared.h (right):

http://codereview.chromium.org/8790004/diff/2001/ppapi/shared_impl/ppb_graphi...
ppapi/shared_impl/ppb_graphics_3d_shared.h:25: : public
thunk::PPB_Graphics3D_API {
nit: wrong indent.

Powered by Google App Engine
This is Rietveld 408576698